Fix General's Cry DPS not scaling properly with increased Warcry Cooldown#9636
Merged
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom Mar 15, 2026
Merged
Conversation
Attack speed shouldn't change the DPS of the skill
LocalIdentity
approved these changes
Mar 15, 2026
LocalIdentity
changed the title
Contributor
|
I removed the hit rate override, as that is there so attack speed does not change the DPS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
3.27.0g:
General's Cry spawned clones are now not yet considered to be active, and thus counting against your maximum allowed, until they have activated. Previously, these would count against your maximum at the point where the number of clones to create from a use was calculated, which could cause clones created by a previous warcry to be replaced before they had enough time to act.So cooldown is no needed anymore since mirages will now only get replaced after finishing their action
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: