AI fix for Tincture mods being applied twice when imported from character#9645
Open
Nostrademous wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
AI fix for Tincture mods being applied twice when imported from character#9645Nostrademous wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Nostrademous wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Character-imported tinctures now get normalized back to canonical base lines before PoB rebuilds the item, instead of preserving API-displayed values and scaling them a second time. The matching logic lives in [Item.lua] and handles Rosethorn-style implicit scaling, normal magic tincture mods, and the case where the local increased effect line itself arrives quality-scaled. Character import now calls that normalization step in [ImportTab.lua].
I added focused regression coverage in [TestTinctureImport_spec.lua] for Rosethorn, mixed effect/Mana Burn prefixes, and a quality-scaled local-effect import case.
Before:
After:
Fixes #9644
Fixes #8039