Skip to content

Fix Cast while Channelling trigger interval being rounded to tick rate #9650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Mar 16, 2026
+6 −8
Merged

Fix Cast while Channelling trigger interval being rounded to tick rate #9650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/Modules/CalcTriggers.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,8 @@ local function CWCHandler(env)
output.addsCastTime = processAddedCastTime(env.player.mainSkill, breakdown)

local icdr = calcLib.mod(env.player.mainSkill.skillModList, env.player.mainSkill.skillCfg, "CooldownRecovery") or 1
local adjTriggerInterval = m_ceil(source.skillData.triggerTime * data.misc.ServerTickRate) / data.misc.ServerTickRate
local triggerRateOfTrigger = 1/adjTriggerInterval
local triggerInterval = source.skillData.triggerTime
local triggerRateOfTrigger = 1 / triggerInterval
local triggeredCD = env.player.mainSkill.skillData.cooldown
local cooldownOverride = env.player.mainSkill.skillModList:Override(env.player.mainSkill.skillCfg, "CooldownRecovery")

Expand All @@ -269,8 +269,7 @@ local function CWCHandler(env)
if breakdown then
if triggeredCD or cooldownOverride then
breakdown.TriggerRateCap = {
s_format("Cast While Channeling triggers %s every %.2fs while channeling %s ", triggeredName, source.skillData.triggerTime, source.activeEffect.grantedEffect.name),
s_format("%.3f ^8(adjusted for server tick rate)", adjTriggerInterval),
s_format("Cast While Channeling triggers %s every %.2fs while channeling %s ", triggeredName, triggerInterval, source.activeEffect.grantedEffect.name),
"",
s_format("%.2f ^8(base cooldown of triggered skill)", triggeredCD),
s_format("/ %.2f ^8(increased/reduced cooldown recovery)", icdr),
Expand All @@ -284,8 +283,7 @@ local function CWCHandler(env)
end
else
breakdown.TriggerRateCap = {
s_format("Cast While Channeling triggers %s every %.2fs while channeling %s ", triggeredName, source.skillData.triggerTime, source.activeEffect.grantedEffect.name),
s_format("%.3f ^8(adjusted for server tick rate)", adjTriggerInterval),
s_format("Cast While Channeling triggers %s every %.2fs while channeling %s ", triggeredName, triggerInterval, source.activeEffect.grantedEffect.name),
"",
triggeredName .. " has no base cooldown or cooldown override",
"",
Expand All @@ -294,7 +292,7 @@ local function CWCHandler(env)

local function extraIncreaseNeeded(affectedCD)
if not cooldownOverride then
local nextBreakpoint = effCDTriggeredSkill - adjTriggerInterval
local nextBreakpoint = effCDTriggeredSkill - triggerInterval
local timeOverBreakpoint = triggeredTotalCooldown - nextBreakpoint
local alreadyReducedTime = triggeredTotalCooldown * icdr - triggeredTotalCooldown
if timeOverBreakpoint < affectedCD then
Expand Down Expand Up @@ -377,7 +375,7 @@ local function CWCHandler(env)

-- Account for Trigger-related INC/MORE modifiers
addTriggerIncMoreMods(env.player.mainSkill, env.player.mainSkill)
env.player.output.ChannelTimeToTrigger = source.skillData.triggerTime
env.player.output.ChannelTimeToTrigger = triggerInterval
env.player.mainSkill.skillData.triggered = true
env.player.mainSkill.skillFlags.globalTrigger = true
env.player.mainSkill.skillData.triggerRate = output.SkillTriggerRate
Expand Down
Loading