Show warning when instantiating multiple ruby clients#109
Merged
dustinbyrne merged 2 commits intoPostHog:mainfrom Mar 12, 2026
Merged
Show warning when instantiating multiple ruby clients#109dustinbyrne merged 2 commits intoPostHog:mainfrom
dustinbyrne merged 2 commits intoPostHog:mainfrom
Conversation
- Added a warning mechanism for multiple PostHog client instances created with the same API key to prevent dropped events and inconsistent behavior. - Updated documentation to emphasize the importance of using a single client instance and provided guidance on suppressing the warning if multiple instances are necessary. - Enhanced tests to verify the warning functionality and ensure correct behavior under various conditions. This change improves the reliability of the PostHog integration by promoting best practices for client usage.
Contributor
|
This looks good to me, thanks for submitting! I'll have to circle back to check out the issue with Semgrep failing to run before approving. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #57
AI Disclosure: I used Cursor for this PR.
This change improves the reliability of the PostHog integration by promoting best practices for client usage.