Skip to content

Do not clean up GitHub Action workers if no Docker build is needed#475

Merged
Quetzacoalt91 merged 1 commit intoPrestaShop:masterfrom
Quetzacoalt91:avoid-cleanup-when-not-needed
Mar 24, 2026
Merged

Do not clean up GitHub Action workers if no Docker build is needed#475
Quetzacoalt91 merged 1 commit intoPrestaShop:masterfrom
Quetzacoalt91:avoid-cleanup-when-not-needed

Conversation

@Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Mar 24, 2026

Questions Answers
Description? Based on the run https://github.com/PrestaShop/docker/actions/runs/23484488854, each task of building a base or PrestaShop image takes ~2 minutes even when there is nothing to do. This is caused by the step jlumbroso/free-disk-space that frees space in order to the incoming Docker build to complete. However, 2 minutes * (83-5) jobs equals around 1h and a half (156 minutes) of wasted runners time. This PR adds conditions to avoid running steps that won't be needed, and will speed up the whole workflow.
Type? improvement
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company @PrestaShopCorp
How to test? Check time needed to complete (to be checked on a fork: https://github.com/Quetzacoalt91/docker/actions/runs/23496129187)

Original behavior:

image

Updated result:

image

@Quetzacoalt91 Quetzacoalt91 self-assigned this Mar 24, 2026
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Mar 24, 2026
@Quetzacoalt91 Quetzacoalt91 force-pushed the avoid-cleanup-when-not-needed branch from bbdfafb to 56a1f94 Compare March 24, 2026 14:56
@Quetzacoalt91 Quetzacoalt91 merged commit 56c65ec into PrestaShop:master Mar 24, 2026
2 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Merged in PR Dashboard Mar 24, 2026
@Quetzacoalt91 Quetzacoalt91 deleted the avoid-cleanup-when-not-needed branch March 24, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

2 participants