Skip to content

Trotterisation test update#728

Open
otbrown wants to merge 8 commits intodevelfrom
trotter-test-update
Open

Trotterisation test update#728
otbrown wants to merge 8 commits intodevelfrom
trotter-test-update

Conversation

@otbrown
Copy link
Copy Markdown
Collaborator

@otbrown otbrown commented Apr 17, 2026

Resolves #715

…d statevecs and densmats, and both permutePaulis options
@otbrown
Copy link
Copy Markdown
Collaborator Author

otbrown commented Apr 20, 2026

Bloody quad precision. I suspect calculating exponents is the underlying culprit here. We're probably checking against an overly optimistic absolute error in these. Will tweak it up for these tests.

@otbrown
Copy link
Copy Markdown
Collaborator Author

otbrown commented Apr 20, 2026

Ah, I see REQUIRE_AGREE uses tolerances hard-coded in tests/utils/compare.cpp, not validation epsilon... Also it's only the serial and quad precision tests that fail. What a confounding edge case 😑

@otbrown
Copy link
Copy Markdown
Collaborator Author

otbrown commented Apr 20, 2026

Okay, when tested locally all quad precision configurations failed, so I've applied the epsilon increase for all deployments, not just single-threaded.

@otbrown otbrown marked this pull request as ready for review April 21, 2026 09:38
@otbrown otbrown requested a review from TysonRayJones April 21, 2026 09:38
@otbrown
Copy link
Copy Markdown
Collaborator Author

otbrown commented Apr 21, 2026

Hi @TysonRayJones, hopefully this version of the Trotter tests sparks joy!

We're now using a bit more of the general QuEST testing machinery, and testing across deployments. The unitary time evo tests are a bit trickier, as I really can't think of a way to do that that doesn't involve fixed numbers of qubits, but again I've updated them to work across deployments and test on density matrices as well as statevectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant