Open
Conversation
The Linux wheels were being built as cp38-cp38 instead of cp310-abi3 because the manylinux Docker container doesn't have access to the Python 3.10 interpreter set up by actions/setup-python. Pass `-i python3.10` to maturin for Linux builds to ensure abi3 wheels are built, matching the behavior on macOS and Windows. Fixes Quantco#303 --- This PR was created with assistance from Claude Code (AI). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gab23r
requested review from
Andreas Albert (AndreasAlbertQC),
Oliver Borchert (borchero) and
Daniel Elsner (delsner)
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 56 56
Lines 3218 3218
=========================================
Hits 3218 3218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions build workflow to ensure Linux wheels are built as cp310-abi3 (matching the project’s requires-python >=3.10 / pyo3 abi3 configuration), so Linux users can install from wheels without needing Rust.
Changes:
- Add
-i python3.10tomaturininvocation for Linux wheel builds (x86_64 and aarch64). - Parameterize
maturinarguments via the matrix to keep non-Linux builds unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cp38-cp38instead ofcp310-abi3-i python3.10to maturin for Linux builds to ensure abi3 wheels are producedRoot Cause
The
actions/setup-pythonaction sets up Python 3.10 on the host runner, but this has no effect inside the manylinux Docker container used for Linux builds. The manylinux2014 container's default Python is 3.8, causing maturin to build non-abi3 wheels.From the maturin-action README:
Test plan
cp310-abi3-manylinux*instead ofcp38-cp38-manylinux*Fixes #303
This PR was created with assistance from Claude Code (AI).
🤖 Generated with Claude Code