feat: Refine summary message for equal empty data frames#20
Open
Marius Merkle (MariusMerkleQC) wants to merge 1 commit intomainfrom
Open
feat: Refine summary message for equal empty data frames#20Marius Merkle (MariusMerkleQC) wants to merge 1 commit intomainfrom
Marius Merkle (MariusMerkleQC) wants to merge 1 commit intomainfrom
Conversation
Copilot started reviewing on behalf of
Marius Merkle (MariusMerkleQC)
March 25, 2026 16:34
View session
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 739 742 +3
=========================================
+ Hits 739 742 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR refines Diffly’s “equal” summary output to explicitly call out the special case where both input data frames are empty, addressing exploratory workflows where an “exact match” can be misleading if it’s only due to empty inputs (Solves #18).
Changes:
- Update the equal-summary banner message to indicate emptiness when the compared frames have 0 rows.
- Regenerate/update snapshot fixtures for the
empty_left_rightsummary outputs across formatting permutations.
Reviewed changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| diffly/summary.py | Adjusts the “equal” summary banner to emit an emptiness-specific message when num_rows_left() == 0. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_False_top_False_slim_False_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_False_top_False_slim_False_sample_rows_True_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_False_top_False_slim_True_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_False_top_False_slim_True_sample_rows_True_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_True_sample_pk_True.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_True_sample_pk_True.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_True_top_False_slim_False_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_True_top_False_slim_False_sample_rows_True_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_True_top_False_slim_True_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_True_top_False_slim_True_sample_rows_True_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_True_top_True_slim_True_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_False_perfect_True_top_True_slim_True_sample_rows_True_sample_pk_True.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_False_top_False_slim_False_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_False_top_False_slim_False_sample_rows_True_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_False_top_False_slim_True_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_False_top_False_slim_True_sample_rows_True_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_False_top_True_slim_False_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_False_top_True_slim_False_sample_rows_True_sample_pk_True.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_False_top_True_slim_True_sample_rows_True_sample_pk_True.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_True_top_False_slim_False_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_True_top_False_slim_False_sample_rows_True_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_True_top_False_slim_True_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_True_top_False_slim_True_sample_rows_True_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_True_top_True_slim_True_sample_rows_False_sample_pk_False.txt | Updates expected equal-summary banner text for empty inputs. |
| tests/summary/fixtures/empty_left_right/gen/pretty_True_perfect_True_top_True_slim_True_sample_rows_True_sample_pk_True.txt | Updates expected equal-summary banner text for empty inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Marius Merkle (MariusMerkleQC)
requested review from
EgeKaraismailogluQC and
Oliver Borchert (borchero)
as code owners
EgeKaraismailogluQC
approved these changes
Mar 25, 2026
Collaborator
EgeKaraismailogluQC
left a comment
EgeKaraismailogluQC
left a comment
There was a problem hiding this comment.
Thank you Marius Merkle (@MariusMerkleQC), looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solves #18.
Changes