Skip to content

CI updates for v1.16.8 merge#147

Open
syntrust wants to merge 11 commits intoop-esfrom
op-es-ci-v1.16.8
Open

CI updates for v1.16.8 merge#147
syntrust wants to merge 11 commits intoop-esfrom
op-es-ci-v1.16.8

Conversation

@syntrust
Copy link
Copy Markdown

@syntrust syntrust commented Mar 20, 2026

Test script update based on the v1.16.8 merge.

Successfully ran on AX101: Execution time: 61 minute(s) and 54 second(s)

@syntrust syntrust marked this pull request as ready for review March 25, 2026 02:23
run_step "contracts-bedrock tests setup (go-ffi)" just build-go-ffi

# temporarily skip failed tests that block CI process
SKIP_PATH="test/universal/OptimismMintableERC20Factory.t.sol"
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case can pass when running on its own.

@blockchaindevsh
Copy link
Copy Markdown

blockchaindevsh commented Mar 25, 2026

Why are these tests removed:

  1. op-e2e-fuzz (op-e2e fuzz tests)
  2. cannon-fuzz
  3. fuzz-golang (op-challenger, op-node, op-service, op-chain-ops fuzzing)
  4. go-tests-full (make go-tests-ci)
  5. op-e2e-tests (make test-actions, make test-ws)
  6. op-deployer embedded artifacts (just copy-contract-artifacts)

Are they covered elsewhere?

@blockchaindevsh
Copy link
Copy Markdown

What's your criteria to including jobs into this script?

@syntrust
Copy link
Copy Markdown
Author

What's your criteria to including jobs into this script?

Generally all tests in the main workflow that validate functional correctness (unit, integration, E2E, and fuzz tests) are included.

  • Linting, formatting, and documentation checks are excluded.
  • Jobs related to publishing, PR, or manual dispatch triggers are excluded.
  • Supervisor E2E is excluded

@blockchaindevsh
Copy link
Copy Markdown

blockchaindevsh commented Mar 27, 2026

Can we further simplify this script by calling makefile targets and justfile recipes directly?

@blockchaindevsh
Copy link
Copy Markdown

A comment to .mise-tasks/dev-test.sh about the sources of the steps, and the criteria of choosing them would be very helpful here.

@syntrust
Copy link
Copy Markdown
Author

A comment to .mise-tasks/dev-test.sh about the sources of the steps, and the criteria of choosing them would be very helpful here.

See comments above every run_step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants