Skip to content

[8.2] MOD-14470 Add VecSimParams_GetQueryBlobSize API for safe query vector allocatio#921

Merged
meiravgri merged 1 commit into8.2from
backport-915-to-8.2
Mar 25, 2026
Merged

[8.2] MOD-14470 Add VecSimParams_GetQueryBlobSize API for safe query vector allocatio#921
meiravgri merged 1 commit into8.2from
backport-915-to-8.2

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Mar 25, 2026

Description

Backport of #915 to 8.2.


Note

Low Risk
Low risk: adds a small, self-contained C API helper and unit coverage without changing indexing/search behavior. Main risk is API/ABI exposure and relying on assert for type validation in release builds.

Overview
Adds a new public C API, VecSimParams_GetQueryBlobSize, to compute the required allocation size for query vector blobs that will be passed through VecSim_Normalize, including the extra float norm storage needed for INT8/UINT8 cosine queries.

Updates unit tests to cover the new helper across {VecSimType, VecSimMetric} combinations and hardens CommonTypeMetricTests teardown to avoid freeing a null index.

Written by Cursor Bugbot for commit 40407c6. This will update automatically on new commits. Configure here.

…r allocatio (#915)

* api for VecSimParams_GetQueryBlobSize

* fix dtor

* move index-> null to the test start

* format

(cherry picked from commit 8d37cf1)
@GuyAv46 GuyAv46 marked this pull request as draft March 25, 2026 12:02
@GuyAv46 GuyAv46 marked this pull request as ready for review March 25, 2026 12:02
@GuyAv46 GuyAv46 requested a review from meiravgri March 25, 2026 12:02
@jit-ci
Copy link

jit-ci bot commented Mar 25, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@meiravgri meiravgri enabled auto-merge March 25, 2026 12:11
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.01%. Comparing base (8e80775) to head (40407c6).
⚠️ Report is 2 commits behind head on 8.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              8.2     #921      +/-   ##
==========================================
- Coverage   97.03%   97.01%   -0.03%     
==========================================
  Files         126      126              
  Lines        7353     7359       +6     
==========================================
+ Hits         7135     7139       +4     
- Misses        218      220       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri added this pull request to the merge queue Mar 25, 2026
Merged via the queue into 8.2 with commit 09adad1 Mar 25, 2026
22 of 24 checks passed
@meiravgri meiravgri deleted the backport-915-to-8.2 branch March 25, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant