Conversation
newpavlov
commented
Apr 20, 2026
| /// Apply Ascon permutation with the given number of rounds. | ||
| /// | ||
| /// Results in a compilation error if `ROUNDS` is greater than 12. | ||
| pub const fn permute<const ROUNDS: usize>(state: &mut State) { |
Member
Author
There was a problem hiding this comment.
Note that marking it as const fn means that we will not be able to add target-feature dependent backends.
I think it's fine, since we do not have such plans at the moment and such addition is likely to involve addition of a keccak::Keccak-like structure, so it has to be done in a new breaking release either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the code and focuses it only on permutations.