Move airport fetch to background context in WeatherViewModel#5
Merged
RISCfuture merged 1 commit intomainfrom Apr 12, 2026
Merged
Move airport fetch to background context in WeatherViewModel#5RISCfuture merged 1 commit intomainfrom
RISCfuture merged 1 commit intomainfrom
Conversation
Contributes to fixing SF50-TOLD-1X (DB on main thread). The
setupObservation() method used Task {} which inherits @mainactor,
so container.mainContext fetches ran on the main thread.
Switches to Task.detached with a fresh ModelContext(container) per
iteration, setting self.airport back on MainActor via await
MainActor.run. This preserves the existing didSet observer that
triggers subscribe() on the main actor.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code