Fix launch and terrain hangs; restore iPad UI tests#6
Merged
RISCfuture merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
Addresses two open Sentry issues and the pre-existing iPad UI test failures: - SF50-TOLD-28 (fatal): drop the synchronous purgeStaleNavigationData call from App.init(); NavDataLoader.resetData() already performs the same deletes on its @Modelactor during load, so no main-thread work at launch is required. - SF50-TOLD-27: move the 22-file TerrainRegion filesystem scan in refreshAvailableRegions() onto Task.detached, and mark the URL builders and app-group reads nonisolated so they can run off the main actor. - iPad UI tests (all 47 failing at Extensions.swift:120): iOS 26 Liquid Glass reports keyboard-focused TextFields as not-hittable, so clearAndType's triple-tap select-all fails. Fall back to Cmd+A via typeKey, and enable ConnectHardwareKeyboard in CI so the synthetic keyboard event is delivered. Verified: unit tests 317/317, iPhone UI 47/47, iPad UI 47/47. Cold launch with stale schemaVersion on iPhone/iPad reduced from a watchdog kill (≥2000ms) to ~300ms. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves two open Sentry issues and the pre-existing iPad UI test failures:
App.init()no longer synchronously bulk-deletes 9 SwiftData entities on the main context whenschemaVersionis out of date.NavDataLoader.resetData()already performs the same deletes on its@ModelActorduring load, so the pre-launch purge was redundant.TerrainDataLoader.refreshAvailableRegions()now runs its 22-fileFileManager.fileExistsscan onTask.detached, and the URL builders / app-group reads arenonisolated.main): iOS 26 Liquid Glass reports keyboard-focusedTextFields as not-hittable, soclearAndType'stap(withNumberOfTaps: 3)was failing. Fall back totypeKey(\"a\", modifierFlags: .command), and enableConnectHardwareKeyboardin CI so the synthetic keyboard event is delivered.Test plan
RunAllTests)schemaVersionon iPhone: 300 ms (was ≥2000 ms watchdog kill)schemaVersionon iPad: 355 ms🤖 Generated with Claude Code