Merged
Conversation
Member
Author
|
God damnit, my own PR is causing me to resolve a merge conflict |
…uting-links # Conflicts: # src/app/plugins/react-custom-html-parser.test.tsx # src/app/plugins/react-custom-html-parser.tsx
…uting-links # Conflicts: # src/app/plugins/react-custom-html-parser.test.tsx
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-577-sable.raspy-dream-bb1d.workers.dev | ae66ba6 | pr-577 |
Tue, 31 Mar 2026 12:21:40 GMT |
7w1
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks settings into route-driven navigation instead of local component state. Settings now use canonical
/settings/<section>URLs, render as a shallow modal on desktop, render full-page on mobile, and use route-based open, close, and back behavior so the shell and history handling stay consistent.It also adds shareable settings links with
?focus=targets. Those links can be copied from setting rows, render as internal setting-link pills in chat, route back into the app, and flash the targeted setting after navigation. The settings link base URL is configurable, dynamic per-device rows do not expose copy links because they are not stable across clients, and the settings-specificPermalinknaming has been cleaned up toSettingLinkfor consistency.Screenshots
Recording.2026-03-28.200658.mp4
Type of change
Checklist:
AI disclosure:
This PR moves settings state into the router, adds the shallow desktop modal route renderer and mobile full-page settings flow, introduces canonical settings-link parsing/building plus chat rendering/interception for those links, adds focus-target highlighting and configurable settings-link base URL handling, and polishes the row-level copy-link controls and naming so the settings-link codepath is internally consistent.