reward system for level system

[gg123bb]

Summary

• Add per-level reward roles with multiple roles per level.
• Allow per-reward replacement behavior (replaceable vs. kept rewards).
• Add /manage-levels rewards subcommands to manage rewards in Discord.
• Update localization strings for the new reward commands.

Notes

• Rewards now support multiple roles and per-level replace behavior.
• Existing reward_roles/onlyTopLevelRole remains as fallback.

Testing

• Used /manage-levels rewards add|set|remove|clear|list and verified config updates.

[Copilot]

Pull request overview

Adds a new reward-role configuration model for the levels module (multi-role rewards per level with optional “replace previous” behavior), and wires it into the level-up flow (message-based leveling and cheat-based level/xp edits). Also introduces a new config example file and localization keys intended for reward-management commands.

Changes:

• Add modules/levels/rewards.js helper to resolve per-level rewards and compute replaceable role IDs (with legacy fallback to reward_roles/onlyTopLevelRole).
• Update role-granting logic in messageCreate and manage-levels to use the new reward resolution.
• Add configs/reward-roles.json config schema and extend locales with reward-management strings.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
modules/levels/rewards.js	New reward resolution + replaceable-role computation with legacy fallback
modules/levels/module.json	Registers configs/reward-roles.json as a module config example file
modules/levels/events/messageCreate.js	Uses new reward resolution when granting/removing roles on level-up
modules/levels/configs/reward-roles.json	New config-element schema for per-level rewards (multi-role + replace flag)
modules/levels/commands/manage-levels.js	Updates cheat flows to apply reward roles via new reward helpers
locales/en.json	Adds new reward-management localization keys
locales/de.json	Adds new reward-management localization keys

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

member.roles.add(rewardConfig.roles) returns a Promise but isn’t awaited or caught. If adding the role(s) fails (missing permissions/unknown role), this can surface as an unhandled rejection. Please await it and/or attach .catch() (and consider passing an audit-log reason for consistency with message-based leveling).

[Copilot]

member.roles.add(rewardConfig.roles) returns a Promise but isn’t awaited or caught. If adding the role(s) fails (missing permissions/unknown role), this can surface as an unhandled rejection. Please await it and/or attach .catch() (and consider passing an audit-log reason for consistency with message-based leveling).

Suggested change

	member.roles.add(rewardConfig.roles);
	await member.roles.add(rewardConfig.roles, '[levels] ' + localize('levels', 'granted-rewards-audit-log')).catch();

[Copilot]

PR description mentions adding /manage-levels rewards ... subcommands, and new locale keys for reward-management commands were added, but manage-levels.js currently only defines reset-xp, edit-xp, and edit-level options (no rewards subcommand group). Either implement and register the rewards subcommands in this PR, or update the PR description/remove unused locale keys to avoid drifting docs/UI text.

[Copilot]

getReplaceableRewardRoleIds/getRewardForLevel treat an empty levels['reward-roles'] array the same as “not configured” and fall back to legacy config.reward_roles. Because config-element files are always loaded as an array (often [] by default), there’s no way to intentionally disable rewards via the new config if legacy reward_roles is still populated (e.g., after using a future “clear” command). Consider distinguishing “missing/undefined” from “configured but empty” (e.g., have getRewardEntries return null when the config key is absent/not an array, and only fall back to legacy in that case), or add an explicit flag controlling legacy fallback.

[Copilot]

Level lookup uses parseInt(r.level) === level, which can match unexpected strings like "10abc" and omits an explicit radix. Prefer strict numeric coercion/validation (e.g., Number(r.level) with Number.isInteger) before comparing to level.

Suggested change

	const entry = rewardEntries.find(r => parseInt(r.level) === level);
	const entry = rewardEntries.find(r => {
	const rLevel = Number(r.level);
	return Number.isInteger(rLevel) && rLevel === level;
	});

[Copilot]

Replacement logic builds a flat set of “replaceable role IDs” across all entries with replacePrevious: true. If the same role ID is ever used in both a replaceable reward and a non-replaceable (“kept”) reward, leveling into a replaceable reward will remove that role even if the member has it due to the kept reward. Consider enforcing uniqueness of role IDs across rewards, or tracking replaceability per (level, role) instead of per role ID.

Suggested change

	const roles = new Set();
	if (rewardEntries.length !== 0) {
	for (const entry of rewardEntries) {
	if (!entry.replacePrevious) continue;
	if (!Array.isArray(entry.roles)) continue;
	for (const roleId of entry.roles) roles.add(roleId);
	}
	} else if (moduleConfig.reward_roles) {
	for (const roleId of Object.values(moduleConfig.reward_roles)) roles.add(roleId);
	}
	return [...roles];
	// Track roles that are ever granted with replacePrevious = true vs false
	const replaceableRoles = new Set();
	const keptRoles = new Set();
	if (rewardEntries.length !== 0) {
	for (const entry of rewardEntries) {
	if (!Array.isArray(entry.roles)) continue;
	if (entry.replacePrevious) {
	for (const roleId of entry.roles) {
	if (roleId) replaceableRoles.add(roleId);
	}
	} else {
	for (const roleId of entry.roles) {
	if (roleId) keptRoles.add(roleId);
	}
	}
	}
	} else if (moduleConfig.reward_roles && moduleConfig.onlyTopLevelRole) {
	// Legacy configuration: only treat roles as replaceable when legacy
	// behavior (onlyTopLevelRole) indicates previous roles should be replaced.
	for (const roleId of Object.values(moduleConfig.reward_roles)) {
	if (roleId) replaceableRoles.add(roleId);
	}
	}
	// A role is considered replaceable only if it is never used in a non-replacePrevious entry.
	const effectiveReplaceableRoles = [];
	for (const roleId of replaceableRoles) {
	if (!keptRoles.has(roleId)) {
	effectiveReplaceableRoles.push(roleId);
	}
	}
	return effectiveReplaceableRoles;

[Copilot]

The audit-log reason for adding roles is "[levels]" + localize(...) (missing a space after the tag), while the removal reason uses "[levels] " + .... Consider making these consistent so audit logs read correctly.

[SCDerox]

Hi, thanks so much for your contribution - quick update: Unfortunately I have exams this week, so it might take a few weeks to review everything. Thanks so much for your patience.

Also, I have one question for our internal compliance:

• Please disclose whether Generative Large Language Models ("Generative AI", e.g. Coplilot) were used and to what extent to write this code. In addition, please confirm that you have reviewed and tested any generated code thoroughly. For details, please review our AI Policy.

[SCDerox]

Hi, quickly checking in, any updates on this?