(FEATURE) Filterpicker implementation for SeisComP based on A Lomax (2012)#186
Closed
Donavin97 wants to merge 18 commits intoSeisComP:mainfrom
Closed
(FEATURE) Filterpicker implementation for SeisComP based on A Lomax (2012)#186Donavin97 wants to merge 18 commits intoSeisComP:mainfrom
Donavin97 wants to merge 18 commits intoSeisComP:mainfrom
Conversation
- Implement FilterPicker characteristic function as InPlaceFilter - Allows CF to be used independently from the picker - Can be used as preprocessing filter in scautopick - Available for custom processing chains and analysis - Updated filterpicker plugin to use the new InPlaceFilter - Added documentation for InPlaceFilter usage Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- Document how to use FilterPickerCF as preprocessing filter - Add example configuration for scautopick - Add C++ code example for programmatic usage - Explain benefits of CF preprocessing Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- Fix ButterworthBandpass to use IIR namespace - Fix member initialization order to match declaration - Add SEISCOMP_COMPONENT define Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- Use constructor with parameters instead of setup() - Apply filter to inputData, not original data - Fix apply() call to use (count, data) signature Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- These variables are now internal to FilterPickerCF InPlaceFilter - Simplified debug output Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- Add REGISTER_INPLACE_FILTER macro for FilterPickerCF - Filter can now be used by name: FILTERPICKERCF - Enables use in scautopick configuration Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- Required for proper template instantiation - Filter name: FILTERPICKERCF Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- Changed to 3 parameters: numBands, minFreq, maxFreq - Creates multiple logarithmically-spaced frequency bands - Combines CFs using maximum across all bands - Registered with short name: FP - Usage: FP(5, 1.0, 20.0) or FP(numbands, lowfreq, highfreq) Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- Cannot register same class twice - Use short name FP as primary Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- Create FilterPickerCF as InplaceFilter in math/filter/ - Implements characteristic function computation incrementally - Produces identical results for bulk and sample-by-sample processing - Filter maintains state between apply() calls via IIR filter memory - Registered as 'FP' filter plugin for use in filter chains - Can be combined with any picker (AIC, STALTA, etc.) Usage: picker.filter = "FP(5,0.5,20)" picker = AIC picker.filter = "FP(5,0.5,20)" Fixes PR SeisComP#184 review comment by @gempa-jabe: - Filter now works incrementally (not time-window based) - Properly integrates with filter chains - Separates CF computation from detection logic Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Resolved conflicts in CMakeLists.txt files to use filterpickercf implementation. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Jabe
I made a new PR, because I messe up the last one.
This branch has 2 commits seperating filterpicker plugin and filterpickercf characteristic function.