-
Notifications
You must be signed in to change notification settings - Fork 120
[AMD/ROCm] qwen3.5 fp8 mi355x SGL performance update #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seungrokj
wants to merge
5
commits into
main
Choose a base branch
from
srok/sgl_qwen3.5_fp8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+35
−10
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
609d1f3
SGL qwen3.5 fp8 mi355x performance update
seungrokj 7685bb0
SGL qwen3.5 fp8 mi355x performance update
seungrokj 4f870c8
SGL qwen3.5 fp8 mi355x performance update
seungrokj cee748e
SGL qwen3.5 fp8 mi355x performance update
seungrokj 4e42d21
SGL qwen3.5 fp8 mi355x performance update
seungrokj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The new changelog entry uses a placeholder PR link
pull/9xxinstead of the actual PR number. Since this PR is #995, the link should behttps://github.com/SemiAnalysisAI/InferenceX/pull/995. Please updateperf-changelog.yamlline 1244 to fix the broken link before merging.Extended reasoning...
The changelog entry added by this PR (perf-changelog.yaml, last entry) sets
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/9xx. This is clearly a placeholder that was never replaced with the actual PR number.The specific code path is straightforward: the diff shows the new entry was added at the bottom of
perf-changelog.yamlwithpull/9xxas the PR link. This PR is #995 based on the PR metadata, so the correct value would bepull/995.Existing placeholder entries in the file consistently use the pattern
pull/XXX(all uppercase letters) when the PR number is unknown at write time — for example, entries forkimik2.5-int4-mi300x-vllm,glm5-fp8-mi355x-sglang,minimaxm2.5-fp8-h200-vllm,qwen3.5-bf16-mi325x-sglang, andqwen3.5-fp8-mi325x-sglangall usepull/XXX. Thepull/9xxpattern is a non-standard variant suggesting the author partially began filling in the number (starting with the known digit9) but left it incomplete.The impact is a broken/invalid hyperlink in the changelog. Anyone clicking the link to trace the history of the
qwen3.5-fp8-mi355x-sglangconfiguration change would land on a 404 page instead of this PR.The fix is a one-character change: replace
pull/9xxwithpull/995on line 1244 ofperf-changelog.yaml.Step-by-step proof:
<pr number="995">)pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/9xxhttps://github.com/SemiAnalysisAI/InferenceX/pull/9xxwould 404 since9xxis not a valid PR numberhttps://github.com/SemiAnalysisAI/InferenceX/pull/995would point to this very PR