feat: add full glibc/musl support for all Linux architectures#38
Merged
mikolalysenko merged 1 commit intomainfrom Mar 10, 2026
Merged
feat: add full glibc/musl support for all Linux architectures#38mikolalysenko merged 1 commit intomainfrom
mikolalysenko merged 1 commit intomainfrom
Conversation
Build all 8 Linux target combinations (4 arches x 2 libcs) with explicit -gnu/-musl npm package naming and the libc field so npm installs the correct binary automatically. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-gnu/-muslsuffixes and thelibcfield so npm installs the correct binary automaticallyinstall.shand split PyPI wheel tags into separate glibc (manylinux) and musl (musllinux) buildsNew build targets
x86_64-unknown-linux-gnu(new)x86_64-unknown-linux-muslaarch64-unknown-linux-gnuaarch64-unknown-linux-musl(new)arm-unknown-linux-gnueabihfarm-unknown-linux-musleabihf(new)i686-unknown-linux-gnui686-unknown-linux-musl(new)Files changed
.github/workflows/release.yml— 4 new matrix entries, 4→8 staging linesnpm/socket-patch-linux-*-{gnu,musl}/— 8 new platform packages (replaces 4 old ones)npm/socket-patch/package.json— 4→8 Linux optionalDependenciesnpm/socket-patch/bin/socket-patch— array-based PLATFORMS with glibc/musl candidatesnpm/socket-patch/bin/socket-patch.test.mjs— updated for new formatscripts/install.sh— libc detection (ldd + ld-musl glob)scripts/build-pypi-wheels.py— 4 new musllinux targets, split x86_64 dual-tagTest plan
node --test npm/socket-patch/bin/socket-patch.test.mjs— 4/4 passing🤖 Generated with Claude Code