Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix incorrect year values being persisted from HTML date / datetime-local form inputs by changing when basicField triggers saves, to avoid saving intermediate values while the user is still editing the date.
Changes:
- Detect
date/datetime-localinput types and introducedeferWhileFocusedbehavior. - Skip saving on
changeevents while the date input still has focus. - Avoid disabling date/datetime inputs during the save flow (while preserving the disable behavior for other field types).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@SharonStrats I've opened a new pull request, #708, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
bourgeoa
left a comment
There was a problem hiding this comment.
Tested on contacts-pane and works perfectly
|
@bourgeoa I leave it to you to merge when appropriate. Maybe together with the new contacts-pane work? |
|
I cannot test this locally, but as no comment here nor on the related issue discusses this point --
Anywhere a birthdate or similar date picker shows up, it should start with current date values (e.g., year 2026, not year 1), as this will be a far shorter scroll for the user. |
|
@TallTed it starts from current year by default or date already set |
|
@bourgeoa — I guess things have changed since 2024, or the "already set" was |
When you enter the year in a form it would save before you completed the year and come up with the wrong year. This should fix that.
This happens in a few places, contacts-pane, profile-pane (edit profile), schedulePane probably meeting-pane as well.
I tested this on schedulePane.js in solid-panes and it worked.
SolidOS/solidos#206