fix: BED-6026 adding the domainSid to _unresolvablePrincipals cache to prevent repeated resolving#219
Draft
fix: BED-6026 adding the domainSid to _unresolvablePrincipals cache to prevent repeated resolving#219
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SH tries to repeatedly resolve unresolvable SIDs from a non-domain-joined Windows machine.
Motivation and Context
https://specterops.atlassian.net/browse/BED-6026
#203
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: