Skip to content

fix: BED-6026 adding the domainSid to _unresolvablePrincipals cache to prevent repeated resolving#219

Draft
ktstrader wants to merge 2 commits intov4from
kstrader/BED-6026
Draft

fix: BED-6026 adding the domainSid to _unresolvablePrincipals cache to prevent repeated resolving#219
ktstrader wants to merge 2 commits intov4from
kstrader/BED-6026

Conversation

@ktstrader
Copy link
Copy Markdown
Contributor

Description

SH tries to repeatedly resolve unresolvable SIDs from a non-domain-joined Windows machine.

Motivation and Context

https://specterops.atlassian.net/browse/BED-6026
#203

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant