chore: SHC has a required dependency of SharpHoundRPC

[lrfalslev]

Description

Both CommonLib and RPC use shared Build.Props version property.
Add readmes to nuget packages.
Nuget manages RPC dependency isntead of manually copying built files from RPC to CommonLib.

Motivation and Context

BED-3959

How Has This Been Tested?

Ran dotnet pack and validated output.

Screenshots (if appropriate):

Types of changes

• Chore (a change that does not modify the application functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• Documentation updates are needed, and have been made accordingly.
• I have added and/or updated tests to cover my changes.
• All new and existing tests passed.
• My changes include a database migration.

[coderabbitai]

Walkthrough

The changes introduce centralized build configuration via Directory.Build.props that standardizes project metadata and settings, add package documentation for SharpHoundCommon and SharpHoundRPC, and update project files to remove redundant metadata now inherited from the directory-level configuration and include README references for NuGet packages.

Changes

Cohort / File(s)	Summary
Build Configuration Directory.Build.props	Added centralized PropertyGroup defining build-wide metadata: TargetFramework (net472), OutputType (library), LangVersion (default), and package properties (PackageLicenseExpression, RepositoryUrl, Version, Authors, Company).
CommonLib Package src/CommonLib/README.md, src/CommonLib/SharpHoundCommonLib.csproj	Added documentation describing purpose, requirements, installation, and capabilities. Updated project file to remove inherited metadata, add PackageReadmeFile, enable AllowUnsafeBlocks, and consolidate NuGet packaging rules; removed custom packaging targets.
SharpHoundRPC Package src/SharpHoundRPC/README.md, src/SharpHoundRPC/SharpHoundRPC.csproj	Added documentation outlining scope and intended usage. Updated project file to remove inherited metadata, add PackageReadmeFile, and replace folder entries with system assembly references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 With builds now neat and configs clean,
Two packages documented, pristine!
Metadata shared from one brave file,
Duplication gone—a config smile. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: making SharpHoundRPC an explicit required dependency of SharpHoundCommon, which is reflected in the project file modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description covers the required sections (Description, Motivation, Testing, Types of changes, Checklist) but lacks detail on how the dependency transition was tested and how the package output was validated.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch lfalslev/bed-3959

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/CommonLib/README.md (1)

11-12: Minor grammar fix: hyphenate compound modifier.

"Active Directory oriented" should be hyphenated when used as a compound adjective.

📝 Suggested fix

 - .NET Framework 4.7.2
-- Windows and Active Directory oriented workloads
+- Windows and Active Directory-oriented workloads

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/CommonLib/README.md` around lines 11 - 12, Update the README line
"Windows and Active Directory oriented workloads" to hyphenate the compound
modifier as "Windows and Active Directory-oriented workloads"; locate the phrase
in src/CommonLib/README.md and change only the punctuation/spacing so the
compound adjective "Active Directory-oriented" is correctly hyphenated.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/CommonLib/README.md`:
- Around line 11-12: Update the README line "Windows and Active Directory
oriented workloads" to hyphenate the compound modifier as "Windows and Active
Directory-oriented workloads"; locate the phrase in src/CommonLib/README.md and
change only the punctuation/spacing so the compound adjective "Active
Directory-oriented" is correctly hyphenated.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5a90425e-3a2d-4e1a-92ae-972f34d681b7

📥 Commits

Reviewing files that changed from the base of the PR and between c8fd708 and 8afe88e.

📒 Files selected for processing (5)

• Directory.Build.props
• src/CommonLib/README.md
• src/CommonLib/SharpHoundCommonLib.csproj
• src/SharpHoundRPC/README.md
• src/SharpHoundRPC/SharpHoundRPC.csproj