Further Improve robustness of model classifier tests#4450
Open
chrishalcrow wants to merge 1 commit intoSpikeInterface:mainfrom
Open
Further Improve robustness of model classifier tests#4450chrishalcrow wants to merge 1 commit intoSpikeInterface:mainfrom
chrishalcrow wants to merge 1 commit intoSpikeInterface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging (#4447), there were still flakey failures in the tests.
This PRs makes the training data more robust in two ways:
When testing before, I used
pytestscountflag. This was stupid: the test was using a cache so wasn't retrained each time. This time I ran the test repeatedly from scratch using something likeThanks Gemini!
No failures on 1000 runs :)