BUGFIX: LOC record latitude/longitude overflow on 32 bit archs#4194
Open
al20ov wants to merge 1 commit intoStackExchange:mainfrom
Open
BUGFIX: LOC record latitude/longitude overflow on 32 bit archs#4194al20ov wants to merge 1 commit intoStackExchange:mainfrom
al20ov wants to merge 1 commit intoStackExchange:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 045-loc.js test fails for me on i686:
So in pkg/js/helpers.js, I found out that the bit shift operator always returns a signed int32 which means
1 << 31evaluates to -2147483648 whereasMath.pow(2, 31)gives the correct value of +2147483648 for the equator and prime meridian.And in models/record.go,
LocLatitudeandLocLongitudeinUnmarshalJSONwere typed asintwhich didn't match the main struct or RFC 1876 apparently and on 32 bit architectures,intends up as a signed 32 bit integer and any lat/lon coordinates north of the equator or east of the prime meridian can overflow that which causesjson.Unmarshalto fail.