Fix missing activation checkpointing (recompute) parameters in bridge mode#1833
Open
XJL010622 wants to merge 2 commits intoTHUDM:mainfrom
Open
Fix missing activation checkpointing (recompute) parameters in bridge mode#1833XJL010622 wants to merge 2 commits intoTHUDM:mainfrom
XJL010622 wants to merge 2 commits intoTHUDM:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When using
megatron_to_hf_mode == "bridge", theAutoBridge.from_hf_pretrained()method generates a model provider based strictly on the HuggingFaceconfig.json. However, HF configurations only define the static model architecture and do not contain training-specific memory optimization arguments such as activation checkpointing (recompute).Consequently, critical arguments like
recompute_granularityare lost during the provider initialization. This causes activation checkpointing to fail silently, leading to unexpected and severe OOM (Out of Memory) errors during training, especially for large models or long context windows.Modifications
This PR explicitly synchronizes the recompute-related parameters from the command-line
argsto theproviderbeforeprovider.finalize()is called.We use a safe iteration over
hasattr(args, ...)to ensure compatibility even if certain recompute arguments are not passed in the specific launch script.Changed Code snippet (for review)
In
get_model_provider_func(inside thebridgeconditional branch):