Rewrite Type Syntax Elements Tests and Refactor Type Syntax Elements#460
Open
alexanderlinne wants to merge 3 commits intomainfrom
Open
Rewrite Type Syntax Elements Tests and Refactor Type Syntax Elements#460alexanderlinne wants to merge 3 commits intomainfrom
alexanderlinne wants to merge 3 commits intomainfrom
Conversation
Collaborator
alexanderlinne
commented
Mar 27, 2026
- Splits the DependencyAssembly into two separate assemblies for Types and Methods
- Rewrite of the TypeSyntaxElementsTests similar to Add Tests For Object Predicates #393
- Refactoring of the Type Syntax Elements similar to Refactor Object Syntax Elements #414
…hodDependencyAssembly Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
+ Coverage 77.26% 79.76% +2.50%
==========================================
Files 259 259
Lines 14311 13604 -707
Branches 1353 1273 -80
==========================================
- Hits 11057 10851 -206
+ Misses 2845 2362 -483
+ Partials 409 391 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
cecc978 to
0e11022
Compare
mak638
reviewed
Mar 27, 2026
| Description: TypeNamespace.OuterClassA+InnerClassA is not nested in | ||
| Message: | ||
| "Types that are "TypeNamespace.OuterClassA+InnerClassA" should be nested in no types (always false)" failed: | ||
| TypeNamespace.OuterClassA+InnerClassA is not nested in |
Collaborator
There was a problem hiding this comment.
This seems as if the description is missing a word. Even if we test for "no types" the description shouldn't end mid sentence, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.