Skip to content

Rewrite Type Syntax Elements Tests and Refactor Type Syntax Elements#460

Open
alexanderlinne wants to merge 3 commits intomainfrom
type-syntax-elements-tests
Open

Rewrite Type Syntax Elements Tests and Refactor Type Syntax Elements#460
alexanderlinne wants to merge 3 commits intomainfrom
type-syntax-elements-tests

Conversation

@alexanderlinne
Copy link
Copy Markdown
Collaborator

…hodDependencyAssembly

Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 96.40719% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.76%. Comparing base (f630718) to head (0e11022).

Files with missing lines Patch % Lines
...T/Fluent/Syntax/Elements/Types/AddTypeCondition.cs 85.71% 3 Missing ⚠️
...T/Fluent/Syntax/Elements/Types/AddTypePredicate.cs 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   77.26%   79.76%   +2.50%     
==========================================
  Files         259      259              
  Lines       14311    13604     -707     
  Branches     1353     1273      -80     
==========================================
- Hits        11057    10851     -206     
+ Misses       2845     2362     -483     
+ Partials      409      391      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
@alexanderlinne alexanderlinne force-pushed the type-syntax-elements-tests branch from cecc978 to 0e11022 Compare March 27, 2026 15:31
Description: TypeNamespace.OuterClassA+InnerClassA is not nested in
Message:
"Types that are "TypeNamespace.OuterClassA+InnerClassA" should be nested in no types (always false)" failed:
TypeNamespace.OuterClassA+InnerClassA is not nested in
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems as if the description is missing a word. Even if we test for "no types" the description shouldn't end mid sentence, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants