Draft
Conversation
🦋 Changeset detectedLatest commit: 8048d9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 8048d9d
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/devtools
@tanstack/devtools-client
@tanstack/devtools-ui
@tanstack/devtools-utils
@tanstack/devtools-vite
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/preact-devtools
@tanstack/react-devtools
@tanstack/solid-devtools
@tanstack/vue-devtools
commit: |
harry-whorlow
force-pushed
the
extract-theme-provider
branch
from
cddbb15 to
2c03299
Compare
This was referenced Mar 12, 2026
harry-whorlow
commented
Mar 12, 2026
| theme: 'light' | 'dark', | ||
| importFn: () => Promise<{ default: () => JSX.Element }>, | ||
| importFn: () => Promise<{ | ||
| default: (props: { theme: 'light' | 'dark' }) => JSX.Element |
Collaborator
Author
There was a problem hiding this comment.
nts, use ThemeType
harry-whorlow
commented
Mar 12, 2026
| */ | ||
| export function constructCoreClass( | ||
| importFn: () => Promise<{ default: () => JSX.Element }>, | ||
| importFn: () => Promise<{ default: (props: DevtoolProps) => JSX.Element }>, |
Collaborator
Author
There was a problem hiding this comment.
nts: perhaps make a generic extending DevtoolProps
harry-whorlow
force-pushed
the
extract-theme-provider
branch
from
b0fb67b to
8048d9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves theme provider out of utils. Currently a mismatch of devtools and devtools utils will result in breaking an application. Relocating the theme provider to the respective devtools will stop these errors.