Skip to content

Refine ad script error suppression logic#752

Open
sentry[bot] wants to merge 2 commits intomainfrom
seer/refine-ad-error-suppression
Open

Refine ad script error suppression logic#752
sentry[bot] wants to merge 2 commits intomainfrom
seer/refine-ad-error-suppression

Conversation

@sentry
Copy link
Contributor

@sentry sentry bot commented Mar 12, 2026

Fixes TANSTACK-COM-2E2. The issue was that: Third-party ad script in cross-origin iframe attempts to access window.top.document, which is null in Safari, causing a TypeError.

  • Introduced new conditions to suppress ad script errors based on specific error messages.
  • Allows for suppression of unambiguous ad script errors (e.g., Publift Fuse) even when the ad script frame is not visible in the stack trace.
  • Added checks for messages like 'window.top.document' or 'isPlacementXdom' to identify these errors directly.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 11666816

Not quite right? Click here to continue debugging with Seer.

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2026

⚠️ No Changeset found

Latest commit: e49daa9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 12, 2026

Deploy Preview for tanstack ready!

Name Link
🔨 Latest commit e49daa9
🔍 Latest deploy log https://app.netlify.com/projects/tanstack/deploys/69b315f7aae3cc000862a752
😎 Deploy Preview https://deploy-preview-752--tanstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28 (🟢 up 7 from production)
Accessibility: 90 (no change from production)
Best Practices: 75 (🔴 down 8 from production)
SEO: 97 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants