odb: implement wire bbox test in test_block (Python + TCL)#9817
Open
rohithsiddi wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
odb: implement wire bbox test in test_block (Python + TCL)#9817rohithsiddi wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
rohithsiddi wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: rohithsiddi <rohithsiddi7@gmail.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fill in the
# TODO ADD WIREstub that has been present inblock_placementstep 5 of both
test_block.pyandtest_block.tcl. Add the correspondingtest_bbox5test in both files to verify that adbWirecorrectly expandsthe block bounding box.
(0, 4500)to(3000, 4500)on layer L1 (width 200) using
dbWireEncoderxMaxintest_bbox5is 3100, not 3000: each wire endpoint is extended byhalf the wire width (100) in the direction of travel
Test plan
ctest -R "odb\.test_block" -V— 7 Python tests pass, TCL test passesctest -R "odb\.test_destroy" -V— existing tests unaffected