Skip to content

odb: implement wire bbox test in test_block (Python + TCL)#9817

Open
rohithsiddi wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
rohithsiddi:odb-test-block-wire
Open

odb: implement wire bbox test in test_block (Python + TCL)#9817
rohithsiddi wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
rohithsiddi:odb-test-block-wire

Conversation

@rohithsiddi
Copy link
Contributor

Summary

Fill in the # TODO ADD WIRE stub that has been present in block_placement
step 5 of both test_block.py and test_block.tcl. Add the corresponding
test_bbox5 test in both files to verify that a dbWire correctly expands
the block bounding box.

  • Creates a net and encodes a horizontal wire from (0, 4500) to (3000, 4500)
    on layer L1 (width 200) using dbWireEncoder
  • xMax in test_bbox5 is 3100, not 3000: each wire endpoint is extended by
    half the wire width (100) in the direction of travel

Test plan

  • ctest -R "odb\.test_block" -V — 7 Python tests pass, TCL test passes
  • ctest -R "odb\.test_destroy" -V — existing tests unaffected

Signed-off-by: rohithsiddi <rohithsiddi7@gmail.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a test case for wire bounding boxes in Python and TCL. My review focuses on improving code maintainability by replacing magic numbers with named constants, in line with the repository's general rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant