fix: man_tcl_check tests fail on count mismatch#9830
Open
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
fix: man_tcl_check tests fail on count mismatch#9830oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Previously, man_tcl_check tests passed even when help/proc/readme counts didn't match because .ok golden files encoded the broken state. Add sys.exit(1) so the Python script exits non-zero on mismatch, and add set -o pipefail to regression_test.sh so the exit code propagates through the tee pipe. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
3 tasks
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
luarss
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sys.exit(1)to all 24*_man_tcl_check.pyscripts when help/proc/readme counts don't matchset -o pipefailtotest/regression_test.shso non-zero exit codes propagate through theteepipePreviously these tests passed even with mismatched counts because the
.okgolden files encoded the broken state, and the pipe toteeswallowed the exit code.Test plan
bazelisk test //src/drt/test:drt_man_tcl_check-py_test— PASSES (counts match)bazelisk test //src/ant/test:ant_man_tcl_check-py_test— FAILS (counts don't match, as expected)🤖 Generated with Claude Code