build: migrate chisel_binary to bazel bcr rules_chisel#9834
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully migrates the Chisel build system from @bazel-orfs to @rules_chisel. This involves updating the MODULE.bazel file to include the new rules_chisel dependency and configure its toolchain, as well as updating the BUILD file in test/orfs/mock-array to load chisel_binary from the correct location. The changes are functionally correct for the migration.
|
clang-tidy review says "All clean, LGTM! 👍" |
oharboe
changed the title
oharboe
force-pushed
the
bazel-orfs-bump-chisel
branch
from
e279e25 to
a39b574
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
The local bazel-orfs moved chisel support from @bazel-orfs//toolchains/scala:chisel.bzl to the standalone @rules_chisel//chisel:defs.bzl package. Add rules_chisel as a dev dependency, configure the chisel extension toolchain, and update the mock-array BUILD load path accordingly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
force-pushed
the
bazel-orfs-bump-chisel
branch
from
a39b574 to
215843a
Compare
oharboe
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
|
/gemini review |
|
@maliberty Don't care about pr-head when pr-merge works. |
maliberty
merged commit 201c137
into
The-OpenROAD-Project:master
|
I don't understand why we need chisel at all - shouldn't that come from bazel-orfs? |
The chisel version that we use in mock-array is defined by OpenROAD. mock-array has a chisel version internally that is a developer dependency. Besides, chisel was only empherally supported by bazel-orfs, now its in bazel bcr. |
2 participants
The local bazel-orfs moved chisel support from
@bazel-orfs//toolchains/scala:chisel.bzl to the standalone @rules_chisel//chisel:defs.bzl package. Add rules_chisel as a dev dependency, configure the chisel extension toolchain, and update the mock-array BUILD load path accordingly.