odb: rename RSeg capacitance getters and remove unused code#9835
Merged
eder-matheus merged 1 commit intoThe-OpenROAD-Project:masterfrom Mar 19, 2026
Merged
odb: rename RSeg capacitance getters and remove unused code#9835eder-matheus merged 1 commit intoThe-OpenROAD-Project:masterfrom
eder-matheus merged 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the clarity of the dbRSeg API by renaming capacitance getters. The ambiguous getCapacitance method is replaced with getGroundCapacitance and a new getTotalCapacitance method, making the distinction between ground and total capacitance explicit. An unused method, getSourceCapacitance, has also been removed. All call sites have been updated accordingly. These changes enhance code readability and maintainability without altering functionality. The refactoring is well-executed and I have no further suggestions.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
eder-matheus
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to The-OpenROAD-Project/OpenROAD-flow-scripts#3969.
Context
Among other capacitance related APIs,
dbRSeghad twogetCapacitancemethods for retrieving capacitance - one overloading the other. In order for us to know if we were using only ground or total (ground + coupling) capacitance, we'd need to rely on the parameters which makes our life harder i.e., the naming didn't help at all.Changes
Instead of overloading, having two distinct method names (one for ground, other for total capacitance) so that we can easily know what type of capacitance is being retrieved.
Note that I kept the
getCapacitance(corner, miller_mult)method to maintain the possibility of retrieving a capacitance with a custom coupling scaling - see what is being called insidegetTotalCapacitancefor better understanding.I also removed a function that wasn't being used and seemed somewhat incomplete.