Skip to content

Pyside#409

Open
azfoo wants to merge 8 commits intoTimeLineAnnotator:devfrom
azfoo:pyside
Open

Pyside#409
azfoo wants to merge 8 commits intoTimeLineAnnotator:devfrom
azfoo:pyside

Conversation

@azfoo
Copy link
Copy Markdown
Collaborator

@azfoo azfoo commented Mar 21, 2026

Incoming patches for broken bits in the compiled app

closes #408

@azfoo azfoo force-pushed the pyside branch 3 times, most recently from 0a30bf7 to 748d5db Compare March 23, 2026 18:52
@azfoo azfoo marked this pull request as ready for review March 24, 2026 14:52
@azfoo azfoo requested a review from FelipeDefensor March 24, 2026 14:52
Copy link
Copy Markdown
Collaborator

@FelipeDefensor FelipeDefensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't hanging tests fail? Are there any specifics tests that are hanging on CI?

I am starting locals builds.

@FelipeDefensor
Copy link
Copy Markdown
Collaborator

Now I am getting a different error on the Windows binary built locally:


PS C:\Users\Felipe\dev\tilia-desktop\build\win\exe> Traceback (most recent call last):
  File "C:\Users\Felipe\AppData\Local\TiLiA\V0515~1.0\__main__.py", line 72, in <module>
  File "C:\Users\Felipe\AppData\Local\TiLiA\V0515~1.0\__main__.py", line 64, in main
  File "C:\Users\Felipe\AppData\Local\TiLiA\V0515~1.0\tilia\boot.py", line 43, in boot
  File "C:\Users\Felipe\AppData\Local\TiLiA\V0515~1.0\tilia\boot.py", line 95, in setup_ui
  File "C:\Users\Felipe\AppData\Local\TiLiA\V0515~1.0\tilia\ui\qtui.py", line 152, in __init__
  File "C:\Users\Felipe\AppData\Local\TiLiA\V0515~1.0\tilia\ui\qtui.py", line 333, in _setup_widgets
  File "C:\Users\Felipe\AppData\Local\TiLiA\V0515~1.0\tilia\ui\timelines\collection\collection.py", line 83, in __init__
  File "C:\Users\Felipe\AppData\Local\TiLiA\V0515~1.0\tilia\ui\timelines\collection\collection.py", line 129, in _setup_commands
  File "C:\Users\Felipe\AppData\Local\TiLiA\V0515~1.0\tilia\ui\timelines\base\timeline.py", line 115, in subclasses
  File "C:\Users\Felipe\AppData\Local\TiLiA\V0515~1.0\tilia\ui\timelines\base\timeline.py", line 120, in ensure_subclasses_are_available
  File "C:\Users\Felipe\AppData\Local\TiLiA\V0515~1.0\tilia\utils.py", line 15, in get_sibling_packages
  File "C:\Users\Felipe\AppData\Local\TiLiA\V0515~1.0\pathlib.py", line 1056, in iterdir
FileNotFoundError: [WinError 3] Das System kann den angegebenen Pfad nicht finden: 'C:\\Users\\Felipe\\AppData\\Local\\TiLiA\\V0515~1.0\\tilia\\ui\\timelines'

@FelipeDefensor
Copy link
Copy Markdown
Collaborator

Just built locally on the Mac, and the binary opens fine. Should I try Windows again?

@azfoo
Copy link
Copy Markdown
Collaborator Author

azfoo commented Mar 28, 2026

Just built locally on the Mac, and the binary opens fine. Should I try Windows again?

Do you mind investigating the failing tests on mac with Python 3.10?
And yes, if you don't mind. It was working on my end.

@FelipeDefensor
Copy link
Copy Markdown
Collaborator

Do you mind investigating the failing tests on mac with Python 3.10?
And yes, if you don't mind. It was working on my end.

Will do both.

@FelipeDefensor
Copy link
Copy Markdown
Collaborator

Good news: Build works on my Windows 🎉.
Bad news: Tests do not fail on my Mac with Python 3.10. I am setting up act to run the workflow locally and debug. Not sure I will be done today.

@FelipeDefensor
Copy link
Copy Markdown
Collaborator

Actually, I don't think there is a way to run GitHub's Mac image using docker, so I would need to use my own environment to run the actions, and, as I said, I get no error when running the test with Python 3.10 on my Mac.

Taking a look at the logs, it seems that Ubuntu fails in a similar way with Python 3.10. Have you tried debugging that? It seems the very first test already fails, but I don't see the traceback, which could be very useful for this case. Maybe we could use the -x pytest flag to exit on the first failure? Would we get the traceback then or is this a GitHub Actions thing?

apparently needs to be a list of strings
python/cpython#90149
@azfoo
Copy link
Copy Markdown
Collaborator Author

azfoo commented Mar 30, 2026

Shouldn't hanging tests fail? Are there any specifics tests that are hanging on CI?

They will timeout and be marked as error. No hanging tests at the moment, but this would hopefully allow the rest of the tests to continue should one get stuck.

Bad news: Tests do not fail on my Mac with Python 3.10.

Seems like some kind of a known regression problem that appears in some places. But fixed for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants