Open
Conversation
- Replace removed smart_unicode/force_text with smart_str/force_str - Replace removed ugettext_lazy with gettext_lazy - Fix ChoiceField._set_choices removed in Django 5.0; use forms.ChoiceField.choices.fset() instead Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Use list(attrs.items()) to avoid RuntimeError from mutating dict during iteration (attrs.pop() inside the comprehension) - Remove fields.sort(lambda) call: cmp() doesn't exist in Python 3, and creation_counter was removed in Django 5.x. Python 3.7+ dicts preserve insertion order, making the sort unnecessary. - Use list(base.base_fields.items()) for Python 3 compatibility (dict.items() returns a view, not a list, so + concatenation fails) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.