Open
Conversation
|
It looks like |
felipesere
force-pushed
the
enops-1202-httproute-name
branch
from
66a4820 to
d269ed5
Compare
felipesere
force-pushed
the
enops-1202-httproute-name
branch
from
d269ed5 to
e4e3c1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new field to the canary to customise the HTTPRoute name.
This prevents Flagger from accidentally taking over a pre-existing HTTProute.
If left unconfigured, the current behaviour of using the apex service name stays in place.
This PR also includes a revert to check for
observedGenerationthat is incompatible with our Linkerd setup.Considering moving that behind a flag.