Conversation
DIMS/ParseSamplesheet.nf
Outdated
| path('init.RData') | ||
| path('replication_pattern.txt') |
There was a problem hiding this comment.
outputs are missing emit statements
There was a problem hiding this comment.
Emit statement is only required for the first output (correct me if I'm wrong); the second is not used elsewhere in the pipeline.
Emit statement added.
There was a problem hiding this comment.
If the second output is not used, then why is it mentioned as an output file at all?
There was a problem hiding this comment.
It is my intention to replace init.RData by replication_pattern.txt in other steps of the pipeline (EvaluateTics and GenerateQCOutput).
There was a problem hiding this comment.
I understand. In that case it would still be good to add an emit statement to both outputs, for consistency sake: https://nf-co.re/docs/guidelines/components/modules#output-channel-emissions
Jorisvansteenbrugge
left a comment
Jorisvansteenbrugge
left a comment
There was a problem hiding this comment.
Great work!
My final request is to add an emit statement to the second output (path('replication_pattern.txt) in DIMS/ParseSamplesheet.nf
2 participants
MakeInit hernoemd naar ParseSamplesheet
Code opgeschoond, replication pattern wordt nu gemaakt adhv de informatie in de samplesheet. Variabele nr_replicates is niet meer nodig. Unit test toegevoegd.