Conversation
| }, | ||
| } | ||
| ) | ||
| ) for i in range(0, len(cog_fields), 25)] |
There was a problem hiding this comment.
I can't help but feel that writing this block this big isn't ideal, I'd maybe seperate the block that generates the embeds lists and pass it to the send message function separately.
This would make this code slightly more readable.
raven0034
left a comment
raven0034
left a comment
There was a problem hiding this comment.
Tested locally; seems to work fine. However, I do agree with Skiros' point on readability - also potentially helpful to give brief ctx about the source of the 25 fields limitation as well, to help maintainability in future. Otherwise happy to merge.
Potential future extension of this is a pagination-based approach rather than multiple embeds.
|
Fair points, I was being a bit lazy with the code. Will add this evening. I agree long term solution is some form of pagination though |
3 participants
Fixes #250