Conversation
| { | ||
| "name": "com.unity.services.relay", | ||
| "expression": "1.0", | ||
| "define": "RELAY_SDK_INSTALLED" |
There was a problem hiding this comment.
In the ticket there few possible answers so I just wonder what is the final conclusion, why we don't need this define?
There was a problem hiding this comment.
The com.unity.services.relay package is very deprecated. The new package is com.unity.services.multiplayer. I'm also not convinced this file was doing anything. There were changes made to the NetworkManagerEditor when this file was landed. I think this file has extension methods that were used by stuff that has since been removed from the editor
There was a problem hiding this comment.
@michalChrobot
I did a double take too because the relay package is still "functional" in 6000.70f1.
Just as a personal sanity check, I went ahead and:
- Created a new project with 6000.0.70f1.
- Installed Relay (this is what used to create the RELAY_SDK_INSTALLED define).
- Installed NG0 v2.1.0. (using Develop-2.0.0)
- Added a NetworkManager with UnityTransport to the SampleScene.
The results where:
- Relay evidently still works but is obviously marked as deprecated with information on what to upgrade to.
- Only with the deprecated relay package installed does the
RELAY_SDK_INSTALLEDget defined.- With this defined,
NetworkManagerRelayIntegrationbecomes declared. - This file is the only file that
RELAY_SDK_INSTALLEDis used.- It used to be there was additional code in the NetworkManager.
- In v1.x.x, here is where it is used.
- This defines
RELAY_INTEGRATION_AVAILABLE(v1.x.x only) which then exposed the "helper tool". - RELAY_INTEGRATION_AVAILABLE does not exist in v2.x.x.
- This defines
- In v1.x.x, here is where it is used.
- It used to be there was additional code in the NetworkManager.
- With this defined,
- Nothing in NGO references the
NetworkManagerRelayIntegration.- The visual part was pulled out awhile back, but it looks like this was not removed with it.
Looks like a very safe removal and really should have been removed when the relay helper tool was removed awhile back.
👍
There was a problem hiding this comment.
Ah, right, totally agree then, especially that as far as I remember BossRoom/Asteroids are using the updated package
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Good catch!
No need to have that hanging around anymore.
💯
|
There is no changelog mention so maybe we can just add this and land |
Yeah... it is a behind the scenes kind of change that will have no impact on users. 👍 |
|
ok, fair point then |
3 participants
Purpose of this PR
Remove reference to deprecated standalone relay SDK
Jira ticket
UUM-131561
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
I don't think this needs a backport?