Skip to content

Change to function #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sindharta wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change to function #763

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fec010d
use shading
sindharta Mar 11, 2026
c97324c
fix
sindharta Mar 11, 2026
c663259
reverse
sindharta Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions ...unity.toonshader/Runtime/UniversalRP/Shaders/UniversalToonBodyDoubleShadeWithFeather.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,27 +12,30 @@ void ToonShading(
)
{
const float3 halfDirection = normalize(viewDirection + lightDirection);
const float baseStepMinusFeather = baseColorStep - _BaseShade_Feather;
const float firstStepMinusFeather = shadeColorStep - _1st2nd_Shades_Feather;


float3 Set_BaseColor = lerp((baseAlbedo * lightIntensity), (baseAlbedo * lightColor), _Is_LightColor_Base);
float3 Set_1st_ShadeColor = lerp((firstShadeAlbedo * lightIntensity), (firstShadeAlbedo * lightColor), _Is_LightColor_1st_Shade);
float3 Set_2nd_ShadeColor = lerp((secondShadeAlbedo * lightIntensity), (secondShadeAlbedo * lightColor), _Is_LightColor_2nd_Shade);

//[TODO-sin: 2026-1-27] We can cache the lerp result
float halfLambert = 0.5 * dot(lerp(vertexNormalWS, perturbedNormalWS, _Is_NormalMapToBase), lightDirection) + 0.5;
//only consider shadowAtt when it is valid (dotNL >= 0)
const float dotNL = dot( perturbedNormalWS, lightDirection);
const float dotNL_01 = 0.5 * dotNL + 0.5;
float shadowFactor = lerp(1,shadowAtt,saturate(dotNL));


//shadePosTex. 0: use more-shaded, 1: otherwise
float3 baseColor = lerp(Set_1st_ShadeColor, Set_BaseColor, firstShadePosTex.r);
float3 _1st_shadeColor = lerp(Set_2nd_ShadeColor, Set_1st_ShadeColor, secondShadePosTex.r);

float3 finalColor = ThreeColorsLinearShading(baseColor, _1st_shadeColor, Set_2nd_ShadeColor,
baseColorStep, _BaseShade_Feather, shadeColorStep,
_1st2nd_Shades_Feather, dotNL_01 * shadowFactor);

//[TODO-sin: 2026-1-27] It looks like we only need one channel of firstShadePosTex
float Set_FinalShadowMask = saturate(
1.0 + (lerp(halfLambert, halfLambert * shadowAtt, _Set_SystemShadowsToBase)
- baseStepMinusFeather) * ((1.0 - firstShadePosTex.rgb).r - 1.0) / (baseColorStep - baseStepMinusFeather));
//
//Composition: 3 Basic Colors as Set_FinalBaseColor
float3 finalColor = lerp(Set_BaseColor, lerp(Set_1st_ShadeColor, Set_2nd_ShadeColor,
saturate(( 1.0 + (halfLambert - firstStepMinusFeather) * ((1.0 - secondShadePosTex.rgb).r - 1.0)
/ (shadeColorStep - firstStepMinusFeather)))), Set_FinalShadowMask);
float Set_FinalShadowMask = dotNL_01 * shadowFactor * firstShadePosTex.r;

//[TODO-sin: 2026-3-1] We can cache the lerp result
float specular = 0.5 * dot(halfDirection, lerp(vertexNormalWS, perturbedNormalWS, _Is_NormalMapToHighColor)) + 0.5;

//Specular
Expand Down