Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for TLS 1.3 (which is coming to UnityTLS).
HttpClientand other .NET APIs that use TLS will now offer support for both TLS 1.2 and 1.3 by default unless manually overridden by the user.The core of the changes are in the UnityTLS wrapper where we're changing the default minimum/maximum supported protocol versions. It might look like we're dropping support for TLS 1.0 and 1.1, but that support has been gone from UnityTLS for a while now (it just accepts old versions in protocol ranges for compatibility reasons). I'm not entirely sure the rest of the changes are strictly required here to get TLS 1.3 working, but I thought I might as well add the required definitions in case these enums can be used in the public API somewhere.
Release notes
Improved MTT-14427 @simon-lemay-unity:
Mono: Add support for TLS 1.3 in the networking APIs.
Unity repository changes
This requires changes to UnityTLS. I'm planning to land both Mono and UnityTLS in the same trunk PR.