Enhance ScoreSetHistogram tooltip and relationship handling#660
Open
bencap wants to merge 3 commits intorelease-2026.2.1from
Open
Enhance ScoreSetHistogram tooltip and relationship handling#660bencap wants to merge 3 commits intorelease-2026.2.1from
bencap wants to merge 3 commits intorelease-2026.2.1from
Conversation
…actively We previously loaded relationships lazily once a calibration with classes was the active calibration. This change ensures relationships are loaded proactively, allowing other methods to make use of computed maps immediately.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in how score range labels were displayed in tooltips within the
ScoreSetHistogram.vuecomponent in addition to expanding this logic for class based calibrations, along with related code cleanup and enhancements.Variant classification badge rendering:
getClassificationColor(src/components/score-set/ScoreSetHistogram.vue).UI and UX improvements:
text-linkclass to the ClinVar link for better styling and ensured the score is not'NA'before rendering.conditionallyLoadCalibrationClassVariantsto only check for class-based calibrations, simplifying the logic.