Skip to content

panel : menu : reduce search jank#395

Merged
trigg merged 1 commit intoWayfireWM:masterfrom
AKArien:fix-menu2
Mar 29, 2026
Merged

panel : menu : reduce search jank#395
trigg merged 1 commit intoWayfireWM:masterfrom
AKArien:fix-menu2

Conversation

@AKArien
Copy link
Copy Markdown
Contributor

@AKArien AKArien commented Mar 8, 2026

Reduced jank on search, it now behaves like a proper text input, at the price of eating the first key when user attempts to type while it is not focused.

Addresses #325

@gtaborga
Copy link
Copy Markdown

I look forward to this change. I just discovered this problem when trying to use an on-screen keyboard.

@AKArien
Copy link
Copy Markdown
Contributor Author

AKArien commented Mar 18, 2026

Hey @trigg, in the end, since a few people seem to care about it being fixed asap, I would like it if we could get this current state reviewed and hopefully merged. My experiments for making it smoother probably won’t be ready any time soon.

@AKArien AKArien force-pushed the fix-menu2 branch 2 times, most recently from 44f67a2 to b63ed36 Compare March 18, 2026 09:05
@AKArien AKArien marked this pull request as ready for review March 18, 2026 09:15
Reduced jank on search, it now behaves like a proper text input, with the
caveat of the first key press only recognising simple keys.

Co-authored-by: trigg <triggerhapp@gmail.com>
@AKArien
Copy link
Copy Markdown
Contributor Author

AKArien commented Mar 25, 2026

@trigg hi, finally got to get around to it !
Took the liberty of merging your commit with mine, and i also added the check of the old system of verifying the gdk keyval string is equal to 1, as to avoid inserting strings for other keys (for instance, pressing shift adds « Shift » without this), as well as a comment explaining what is going on with it.

My impressions on this have not changed, while i’m not happy about this being needed and still want to overhaul the menu’s navigation, this is a huge step-up from prior behaviour. If it looks good to you, it looks good to me.

Copy link
Copy Markdown
Collaborator

@trigg trigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for working on this

@trigg trigg merged commit 204bcfa into WayfireWM:master Mar 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants