Skip to content

[MediaCapabilities][GST] Check audio codecs support isConfigurationSu… #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asurdej-comcast wants to merge 1 commit into
base: wpe-2.46
Choose a base branch
from
Open

[MediaCapabilities][GST] Check audio codecs support isConfigurationSu… #1640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,11 +1020,12 @@ ASCIILiteral GStreamerRegistryScanner::configurationNameForLogging(Configuration

GStreamerRegistryScanner::RegistryLookupResult GStreamerRegistryScanner::isConfigurationSupported(Configuration configuration, const MediaConfiguration& mediaConfiguration) const
{
bool isUsingHardware = false;
#ifndef GST_DISABLE_GST_DEBUG
ASCIILiteral configLogString = configurationNameForLogging(configuration);
#endif

Vector<String> allCodecs;

if (mediaConfiguration.video) {
auto& videoConfiguration = mediaConfiguration.video.value();
#ifndef GST_DISABLE_GST_DEBUG
Expand Down Expand Up @@ -1054,12 +1055,7 @@ GStreamerRegistryScanner::RegistryLookupResult GStreamerRegistryScanner::isConfi
if (!isContainerTypeSupported(configuration, contentType.containerType()))
return { false, false, nullptr };

auto codecs = contentType.codecs();
if (!codecs.isEmpty()) {
if (!areAllCodecsSupported(configuration, codecs, false))
return { false, false, nullptr };
isUsingHardware = areAllCodecsSupported(configuration, codecs, true);
}
allCodecs.appendVector(contentType.codecs());
}

if (mediaConfiguration.audio) {
Expand All @@ -1072,6 +1068,15 @@ GStreamerRegistryScanner::RegistryLookupResult GStreamerRegistryScanner::isConfi
auto contentType = ContentType(audioConfiguration.contentType);
if (!isContainerTypeSupported(configuration, contentType.containerType()))
return { false, false, nullptr };

allCodecs.appendVector(contentType.codecs());
}

bool isUsingHardware = false;
if (!allCodecs.isEmpty()) {
if (!areAllCodecsSupported(configuration, allCodecs, false))
return { false, false, nullptr };
isUsingHardware = areAllCodecsSupported(configuration, allCodecs, true);
}

return { true, isUsingHardware, nullptr };
Expand Down