Skip to content

feat(internal/ethapi): createAccessList with stateOverrides #31497#2233

Open
gzliudan wants to merge 2 commits intoXinFinOrg:dev-upgradefrom
gzliudan:createAccessListstateOverrides
Open

feat(internal/ethapi): createAccessList with stateOverrides #31497#2233
gzliudan wants to merge 2 commits intoXinFinOrg:dev-upgradefrom
gzliudan:createAccessListstateOverrides

Conversation

@gzliudan
Copy link
Collaborator

Proposed changes

Ref: ethereum#31497

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Changes that don't change source code or tests
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • revert: Revert something
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Broaden internal/ethapi/api_test.go with content-level parity checks against geth where behavior is compatible.

- Expand RPC retrieval coverage for block/header/receipt and transaction queries, including hash/number selectors, pending/fullTx modes, and not-found paths.
- Add and refine transaction fill/sign/send test paths, including validation and pricing-mode combinations.
- Deepen EstimateGas/Call/CreateAccessList/SimulateV1 assertions for block reference forwarding, state overrides, validation errors, transfer logs, precompile movement, storage state buildup, and VM error reporting.
- Keep the change test-only (single file) with no runtime behavior modifications.
@gzliudan gzliudan changed the title feat(internal/ethapi): CreateAccessList with stateOverrides #31497 feat(internal/ethapi): createAccessList with stateOverrides #31497 Mar 25, 2026
@gzliudan gzliudan force-pushed the createAccessListstateOverrides branch from 2ede8ee to 123c8a0 Compare March 25, 2026 10:09
@coderabbitai
Copy link

coderabbitai bot commented Mar 25, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8e8bea2f-cadc-4e50-8792-5f54f8159a92

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for passing stateOverrides into internal/ethapi’s access-list generation so callers can compute EIP-2930 access lists against an overridden state, and significantly expands internal/ethapi API test coverage around overrides and RPC helpers.

Changes:

  • Extend BlockChainAPI.CreateAccessList / AccessList to accept *override.StateOverride and apply it during access-list creation.
  • Add extensive unit tests covering storage APIs, call/estimate/simulate flows, receipts/block helpers, and the new access-list override behavior.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
internal/ethapi/api.go Adds stateOverrides parameter to access-list generation and applies overrides during AccessList.
internal/ethapi/api_test.go Adds broad test coverage, including new tests for CreateAccessList with state overrides and many RPC/validation scenarios.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gzliudan gzliudan force-pushed the createAccessListstateOverrides branch from 123c8a0 to 36a27ee Compare March 25, 2026 10:13
@gzliudan gzliudan force-pushed the createAccessListstateOverrides branch from 36a27ee to fb95908 Compare March 25, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants