feat(internal/ethapi): createAccessList with stateOverrides #31497#2233
feat(internal/ethapi): createAccessList with stateOverrides #31497#2233gzliudan wants to merge 2 commits intoXinFinOrg:dev-upgradefrom
Conversation
Broaden internal/ethapi/api_test.go with content-level parity checks against geth where behavior is compatible. - Expand RPC retrieval coverage for block/header/receipt and transaction queries, including hash/number selectors, pending/fullTx modes, and not-found paths. - Add and refine transaction fill/sign/send test paths, including validation and pricing-mode combinations. - Deepen EstimateGas/Call/CreateAccessList/SimulateV1 assertions for block reference forwarding, state overrides, validation errors, transfer logs, precompile movement, storage state buildup, and VM error reporting. - Keep the change test-only (single file) with no runtime behavior modifications.
2ede8ee to
123c8a0
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds support for passing stateOverrides into internal/ethapi’s access-list generation so callers can compute EIP-2930 access lists against an overridden state, and significantly expands internal/ethapi API test coverage around overrides and RPC helpers.
Changes:
- Extend
BlockChainAPI.CreateAccessList/AccessListto accept*override.StateOverrideand apply it during access-list creation. - Add extensive unit tests covering storage APIs, call/estimate/simulate flows, receipts/block helpers, and the new access-list override behavior.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/ethapi/api.go | Adds stateOverrides parameter to access-list generation and applies overrides during AccessList. |
| internal/ethapi/api_test.go | Adds broad test coverage, including new tests for CreateAccessList with state overrides and many RPC/validation scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
123c8a0 to
36a27ee
Compare
36a27ee to
fb95908
Compare
Proposed changes
Ref: ethereum#31497
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that