fix(cmd/XDC,internal/cmdtest): stabilize flaky unlock timeout

[gzliudan]

Proposed changes

Make cmdtest kill timeout configurable per test while keeping 30s default.\nSet 90s timeout for TestUnlockFlagAmbiguousWrongPassword to avoid intermittent startup-related timeout failures.

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 12fb2375-5d02-4261-b595-ad5f7cbd5174

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Stabilizes a flaky CLI unlock test by making the cmdtest child-process kill timeout configurable per test (defaulting to the historical 30s), and increasing the timeout for the known flaky case.

Changes:

• Add a KillTimeout field to internal/cmdtest.TestCmd and use it in the internal timeout-kill helper (default 30s).
• Set KillTimeout = 90s for TestUnlockFlagAmbiguousWrongPassword to reduce intermittent startup-related timeouts.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
internal/cmdtest/test_cmd.go	Introduces per-test configurable kill timeout for expect/wait helpers, preserving 30s default.
cmd/XDC/accountcmd_test.go	Applies a longer kill timeout to the flaky ambiguous-unlock wrong-password test.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The doc comment says only the zero value falls back to the default, but withKillTimeout treats any non-positive duration (<= 0) as default. Either update the comment to match the behavior (non-positive) or change the condition to == 0 so negative durations retain their natural semantics (immediate timeout).

Suggested change

	// Zero value falls back to the historical default.
	// Non-positive values (<= 0) fall back to the historical default.