Skip to content

[Accton] Enhance SFP control function in Linux 6.12 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric271110 wants to merge 7 commits into
base: support_linux_6.12
Choose a base branch
from
Open

[Accton] Enhance SFP control function in Linux 6.12 #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
620c196
[Accton][as5812-54x][as7816-64x][as9926-24d] Add SFP functionality (L…
eric271110 Apr 1, 2026
7bf483e
[Accton][as7926-40xfb][as9716-32d][as9737-32db][as7326-56x] Add SFP f…
eric271110 Apr 10, 2026
f032f2d
[Accton][as9817-64d][as9817-64o] Add SFP functionality (TX disable)
eric271110 Apr 13, 2026
9593824
[Accton]Rename macro in sfpi.c
eric271110 Apr 14, 2026
47baae8
[Accton][as7712-32x] Add SFP functionality (LP mode, reset, TX disable)
eric271110 Apr 14, 2026
a3e1156
[Accton] Add sfp read/write return value checking
eric271110 Apr 17, 2026
1eda07e
[Accton] Improve error handling by defaulting return value to error a…
eric271110 Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 75 additions & 36 deletions packages/platforms/accton/x86-64/as5812-54x/modules/builds/x86-64-accton-as5812-54x-cpld.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@
#include <linux/hwmon-sysfs.h>
#include <linux/delay.h>

static const int bit_map[] = {0, 2, 4, 1, 3, 5}; /*for port49~54*/

#define I2C_RW_RETRY_COUNT 10
#define I2C_RW_RETRY_INTERVAL 60 /* ms */

Expand Down Expand Up @@ -104,6 +106,8 @@ MODULE_DEVICE_TABLE(i2c, as5812_54x_cpld_mux_id);
#define TRANSCEIVER_TXDISABLE_ATTR_ID(index) MODULE_TXDISABLE_##index
#define TRANSCEIVER_RXLOS_ATTR_ID(index) MODULE_RXLOS_##index
#define TRANSCEIVER_TXFAULT_ATTR_ID(index) MODULE_TXFAULT_##index
#define TRANSCEIVER_LPMODE_ATTR_ID(index) MODULE_LPMODE_##index
#define TRANSCEIVER_RESET_ATTR_ID(index) MODULE_RESET_##index

enum as5812_54x_cpld1_sysfs_attributes {
CPLD_VERSION,
Expand Down Expand Up @@ -309,6 +313,18 @@ enum as5812_54x_cpld1_sysfs_attributes {
TRANSCEIVER_TXFAULT_ATTR_ID(46),
TRANSCEIVER_TXFAULT_ATTR_ID(47),
TRANSCEIVER_TXFAULT_ATTR_ID(48),
TRANSCEIVER_LPMODE_ATTR_ID(49),
TRANSCEIVER_LPMODE_ATTR_ID(50),
TRANSCEIVER_LPMODE_ATTR_ID(51),
TRANSCEIVER_LPMODE_ATTR_ID(52),
TRANSCEIVER_LPMODE_ATTR_ID(53),
TRANSCEIVER_LPMODE_ATTR_ID(54),
TRANSCEIVER_RESET_ATTR_ID(49),
TRANSCEIVER_RESET_ATTR_ID(50),
TRANSCEIVER_RESET_ATTR_ID(51),
TRANSCEIVER_RESET_ATTR_ID(52),
TRANSCEIVER_RESET_ATTR_ID(53),
TRANSCEIVER_RESET_ATTR_ID(54),
};

/* sysfs attributes for hwmon
Expand All @@ -319,7 +335,7 @@ static ssize_t show_present_all(struct device *dev, struct device_attribute *da,
char *buf);
static ssize_t show_rxlos_all(struct device *dev, struct device_attribute *da,
char *buf);
static ssize_t set_tx_disable(struct device *dev, struct device_attribute *da,
static ssize_t set_control(struct device *dev, struct device_attribute *da,
const char *buf, size_t count);
static ssize_t access(struct device *dev, struct device_attribute *da,
const char *buf, size_t count);
Expand All @@ -334,13 +350,19 @@ static int as5812_54x_cpld_write_internal(struct i2c_client *client, u8 reg, u8
#define DECLARE_TRANSCEIVER_PRESENT_ATTR(index) &sensor_dev_attr_module_present_##index.dev_attr.attr

#define DECLARE_SFP_TRANSCEIVER_SENSOR_DEVICE_ATTR(index) \
static SENSOR_DEVICE_ATTR(module_tx_disable_##index, S_IRUGO | S_IWUSR, show_status, set_tx_disable, MODULE_TXDISABLE_##index); \
static SENSOR_DEVICE_ATTR(module_tx_disable_##index, S_IRUGO | S_IWUSR, show_status, set_control, MODULE_TXDISABLE_##index); \
static SENSOR_DEVICE_ATTR(module_rx_los_##index, S_IRUGO, show_status, NULL, MODULE_RXLOS_##index); \
static SENSOR_DEVICE_ATTR(module_tx_fault_##index, S_IRUGO, show_status, NULL, MODULE_TXFAULT_##index)
#define DECLARE_SFP_TRANSCEIVER_ATTR(index) \
&sensor_dev_attr_module_tx_disable_##index.dev_attr.attr, \
&sensor_dev_attr_module_rx_los_##index.dev_attr.attr, \
&sensor_dev_attr_module_tx_fault_##index.dev_attr.attr
#define DECLARE_QSFP_TRANSCEIVER_SENSOR_DEVICE_ATTR(index) \
static SENSOR_DEVICE_ATTR(module_lpmode_##index, S_IRUGO | S_IWUSR, show_status, set_control, MODULE_LPMODE_##index); \
static SENSOR_DEVICE_ATTR(module_reset_##index, S_IRUGO | S_IWUSR, show_status, set_control, MODULE_RESET_##index);
#define DECLARE_QSFP_TRANSCEIVER_ATTR(index) \
&sensor_dev_attr_module_lpmode_##index.dev_attr.attr, \
&sensor_dev_attr_module_reset_##index.dev_attr.attr

static SENSOR_DEVICE_ATTR(version, S_IRUGO, show_version, NULL, CPLD_VERSION);
static SENSOR_DEVICE_ATTR(access, S_IWUSR, NULL, access, ACCESS);
Expand Down Expand Up @@ -451,6 +473,12 @@ DECLARE_SFP_TRANSCEIVER_SENSOR_DEVICE_ATTR(46);
DECLARE_SFP_TRANSCEIVER_SENSOR_DEVICE_ATTR(47);
DECLARE_SFP_TRANSCEIVER_SENSOR_DEVICE_ATTR(48);

DECLARE_QSFP_TRANSCEIVER_SENSOR_DEVICE_ATTR(49);
DECLARE_QSFP_TRANSCEIVER_SENSOR_DEVICE_ATTR(50);
DECLARE_QSFP_TRANSCEIVER_SENSOR_DEVICE_ATTR(51);
DECLARE_QSFP_TRANSCEIVER_SENSOR_DEVICE_ATTR(52);
DECLARE_QSFP_TRANSCEIVER_SENSOR_DEVICE_ATTR(53);
DECLARE_QSFP_TRANSCEIVER_SENSOR_DEVICE_ATTR(54);
static struct attribute *as5812_54x_cpld1_attributes[] = {
&sensor_dev_attr_version.dev_attr.attr,
&sensor_dev_attr_access.dev_attr.attr,
Expand Down Expand Up @@ -582,6 +610,12 @@ static struct attribute *as5812_54x_cpld3_attributes[] = {
DECLARE_SFP_TRANSCEIVER_ATTR(46),
DECLARE_SFP_TRANSCEIVER_ATTR(47),
DECLARE_SFP_TRANSCEIVER_ATTR(48),
DECLARE_QSFP_TRANSCEIVER_ATTR(49),
DECLARE_QSFP_TRANSCEIVER_ATTR(50),
DECLARE_QSFP_TRANSCEIVER_ATTR(51),
DECLARE_QSFP_TRANSCEIVER_ATTR(52),
DECLARE_QSFP_TRANSCEIVER_ATTR(53),
DECLARE_QSFP_TRANSCEIVER_ATTR(54),
NULL
};

Expand Down Expand Up @@ -673,56 +707,43 @@ static ssize_t show_status(struct device *dev, struct device_attribute *da,
struct i2c_mux_core *muxc = i2c_get_clientdata(client);
struct as5812_54x_cpld_data *data = i2c_mux_priv(muxc);
int status = 0;
u8 reg = 0, mask = 0, revert = 0;
u8 reg = 0, mask = 0, invert = 0;

switch (attr->index) {
case MODULE_PRESENT_1 ... MODULE_PRESENT_8:
reg = 0x6;
mask = 0x1 << (attr->index - MODULE_PRESENT_1);
invert = 1;
break;
case MODULE_PRESENT_9 ... MODULE_PRESENT_16:
reg = 0x7;
mask = 0x1 << (attr->index - MODULE_PRESENT_9);
invert = 1;
break;
case MODULE_PRESENT_17 ... MODULE_PRESENT_24:
reg = 0x8;
mask = 0x1 << (attr->index - MODULE_PRESENT_17);
invert = 1;
break;
case MODULE_PRESENT_25 ... MODULE_PRESENT_32:
reg = 0x6;
mask = 0x1 << (attr->index - MODULE_PRESENT_25);
invert = 1;
break;
case MODULE_PRESENT_33 ... MODULE_PRESENT_40:
reg = 0x7;
mask = 0x1 << (attr->index - MODULE_PRESENT_33);
invert = 1;
break;
case MODULE_PRESENT_41 ... MODULE_PRESENT_48:
reg = 0x8;
mask = 0x1 << (attr->index - MODULE_PRESENT_41);
invert = 1;
break;
case MODULE_PRESENT_49:
reg = 0x14;
mask = 0x1;
break;
case MODULE_PRESENT_50:
reg = 0x14;
mask = 0x4;
break;
case MODULE_PRESENT_51:
case MODULE_PRESENT_49 ... MODULE_PRESENT_54:
reg = 0x14;
mask = 0x10;
break;
case MODULE_PRESENT_52:
reg = 0x14;
mask = 0x2;
break;
case MODULE_PRESENT_53:
reg = 0x14;
mask = 0x8;
break;
case MODULE_PRESENT_54:
reg = 0x14;
mask = 0x20;
mask = 1 << bit_map[attr->index - MODULE_PRESENT_49];
invert = 1;
break;
case MODULE_TXFAULT_1 ... MODULE_TXFAULT_8:
reg = 0x9;
Expand Down Expand Up @@ -796,40 +817,45 @@ static ssize_t show_status(struct device *dev, struct device_attribute *da,
reg = 0x11;
mask = 0x1 << (attr->index - MODULE_RXLOS_41);
break;
case MODULE_LPMODE_49 ... MODULE_LPMODE_54:
reg = 0x16;
mask = 1 << bit_map[attr->index - MODULE_LPMODE_49];
break;
case MODULE_RESET_49 ... MODULE_RESET_54:
reg = 0x15;
mask = 1 << bit_map[attr->index - MODULE_RESET_49];
invert = 1;
break;
default:
return 0;
}

if (attr->index >= MODULE_PRESENT_1 && attr->index <= MODULE_PRESENT_54) {
revert = 1;
}

mutex_lock(&data->update_lock);
status = as5812_54x_cpld_read_internal(client, reg);
if (unlikely(status < 0)) {
goto exit;
}
mutex_unlock(&data->update_lock);

return sprintf(buf, "%d\n", revert ? !(status & mask) : !!(status & mask));
return sprintf(buf, "%d\n", invert ? !(status & mask) : !!(status & mask));

exit:
mutex_unlock(&data->update_lock);
return status;
}

static ssize_t set_tx_disable(struct device *dev, struct device_attribute *da,
static ssize_t set_control(struct device *dev, struct device_attribute *da,
const char *buf, size_t count)
{
struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
struct i2c_client *client = to_i2c_client(dev);
struct i2c_mux_core *muxc = i2c_get_clientdata(client);
struct as5812_54x_cpld_data *data = i2c_mux_priv(muxc);
long disable;
long value;
int status;
u8 reg = 0, mask = 0;
u8 reg = 0, mask = 0, invert = 0;

status = kstrtol(buf, 10, &disable);
status = kstrtol(buf, 10, &value);
if (status) {
return status;
}
Expand Down Expand Up @@ -859,6 +885,15 @@ static ssize_t set_tx_disable(struct device *dev, struct device_attribute *da,
reg = 0xE;
mask = 0x1 << (attr->index - MODULE_TXDISABLE_41);
break;
case MODULE_LPMODE_49 ... MODULE_LPMODE_54:
reg = 0x16;
mask = 1 << bit_map[attr->index - MODULE_LPMODE_49];
break;
case MODULE_RESET_49 ... MODULE_RESET_54:
reg = 0x15;
mask = 1 << bit_map[attr->index - MODULE_RESET_49];
invert = 1;
break;
default:
return 0;
}
Expand All @@ -870,8 +905,12 @@ static ssize_t set_tx_disable(struct device *dev, struct device_attribute *da,
goto exit;
}

/* Update tx_disable status */
if (disable) {
/* Update tx_disable/lpmode/reset status */
if (invert) {
value = !value;
}

if (value) {
status |= mask;
}
else {
Expand Down
Loading