Skip to content

Switch to moby for container operations#154

Open
techknowlogick wants to merge 2 commits intoactions-oss:mainfrom
tklk-forks:moby-dep-update
Open

Switch to moby for container operations#154
techknowlogick wants to merge 2 commits intoactions-oss:mainfrom
tklk-forks:moby-dep-update

Conversation

@techknowlogick
Copy link
Copy Markdown

Based on my experience doing this for xgo: https://github.com/techknowlogick/xgo/blob/main/runtime_docker.go

docker_cli.go has been updated to match: https://github.com/docker/cli/blob/9a471180cb7d39c236d090399a9d362c3f5a8ebd/cli/command/container/opts.go as the newer versions import moby

@ChristopherHX
Copy link
Copy Markdown
Contributor

Thanks,

I wonder why you have submitted this on github.com

  • linux tests good
  • WITHOUT_DOCKER build tag is broken, we need to look at this
  • (lint and snapshot jobs fail due to go 1.24 to 1.26, not a blocker need to merge a fix for them)

@techknowlogick
Copy link
Copy Markdown
Author

@ChristopherHX figured I'd commit this upstream first so that it would eventually make its way to the runner. I updated tags to ensure that none of the docker stuff spills over no-docker, and I bumped CI stuff for later go versions. The longer has some reports for files that weren't touched in this PR, but I thought that would be best solved in a different PR to not extend the scope of this PR (I'm happy to fix it in this PR too if that's what you'd prefer)

@ChristopherHX
Copy link
Copy Markdown
Contributor

I thought that would be best solved in a different PR to not extend the scope of this PR

Silverwind and I already did some work for this, just need to move this from gitea.com/gitea/runner/act up to here.

@techknowlogick
Copy link
Copy Markdown
Author

Ah lol nice. I missed that one. I'll close this PR:)

@techknowlogick techknowlogick deleted the moby-dep-update branch March 20, 2026 16:07
@ChristopherHX
Copy link
Copy Markdown
Contributor

I only meant linting, not this main topic.

@techknowlogick
Copy link
Copy Markdown
Author

@ChristopherHX ah, my apologies. I'll resubmit the PR.

@techknowlogick techknowlogick restored the moby-dep-update branch March 23, 2026 14:30
@techknowlogick
Copy link
Copy Markdown
Author

@ChristopherHX turns out I just had to re-push the branch and it let me re-open this PR

@ChristopherHX
Copy link
Copy Markdown
Contributor

ah ok, thanks

  • need to sort things on my end and continue with merging
  • yes I expected restore branch to be enough

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 72.58383% with 139 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/container/docker_cli.go 67.33% 64 Missing and 18 partials ⚠️
pkg/container/docker_volumespec.go 65.15% 22 Missing and 1 partial ⚠️
pkg/container/docker_run.go 80.89% 10 Missing and 7 partials ⚠️
pkg/container/docker_socket.go 81.25% 5 Missing and 1 partial ⚠️
pkg/container/docker_auth.go 84.37% 4 Missing and 1 partial ⚠️
pkg/container/docker_platform.go 66.66% 2 Missing and 2 partials ⚠️
cmd/root.go 0.00% 0 Missing and 1 partial ⚠️
pkg/container/docker_network.go 87.50% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
pkg/container/docker_build.go 76.66% <100.00%> (+5.41%) ⬆️
pkg/container/docker_images.go 58.62% <100.00%> (+4.56%) ⬆️
pkg/container/docker_pull.go 69.69% <100.00%> (+4.52%) ⬆️
pkg/container/docker_volume.go 68.00% <100.00%> (+5.50%) ⬆️
pkg/runner/runner.go 91.03% <ø> (+3.19%) ⬆️
cmd/root.go 65.00% <0.00%> (+7.42%) ⬆️
pkg/container/docker_network.go 54.76% <87.50%> (+4.76%) ⬆️
pkg/container/docker_platform.go 66.66% <66.66%> (ø)
pkg/container/docker_auth.go 79.06% <84.37%> (+27.71%) ⬆️
pkg/container/docker_socket.go 83.92% <81.25%> (-1.60%) ⬇️
... and 3 more

... and 57 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@techknowlogick
Copy link
Copy Markdown
Author

need to sort things on my end and continue with merging

No worries, lmk if I can help with anything:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants