fix(useTreeData): insert items into a child node with StrictMode#9824
Open
chirokas wants to merge 2 commits intoadobe:mainfrom
Open
fix(useTreeData): insert items into a child node with StrictMode#9824chirokas wants to merge 2 commits intoadobe:mainfrom
chirokas wants to merge 2 commits intoadobe:mainfrom
Conversation
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
Thanks so much for the PR, it'd be great if you could fill in the description. I realise this is a fairly simple one, but it'd be nice to know the original issue and how to reproduce it/how you are using it that results in this issue. Also, any information on how you diagnosed the issue and how you landed on this fix.
It can be easier if an issue is opened first. This gives us a place to discuss the problem and possible fixes. It really helps us evaluate PRs instead of making a bunch of guesses.
Again, thank you for the PR.
| insert(parentKey: Key | null, index: number, ...values: T[]) { | ||
| setItems(({items, nodeMap: originalMap}) => { | ||
| let {items: newNodes, nodeMap: newMap} = buildTree(values, originalMap, parentKey); | ||
| let {items: newNodes, nodeMap: newMap} = buildTree(values, new Map(originalMap), parentKey); |
Member
There was a problem hiding this comment.
should the update function below also do this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: