Mypayment extended

[Rotheem]

Description

Summary

support module payment with MyPayment

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

• support requests
• support direct transfers

Additional Notes

Classification

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
• 🔧 Infra CI/CD (changes to configs of workflows)
• 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
• 😶‍🌫️ No impact for the end-users

Impact & Scope

• Core functionality changes
• Single module changes
• Multiple modules changes
• Database migrations required
• Other: ...

Testing

• 1. Tested this locally
• 2. Added/modified tests that pass the CI (or tested in a downstream fork)
• 3. Tested in a deployed pre-prod
• 0. Untestable (exceptionally), will be tested in prod directly

Documentation

• Updated the docs accordingly :
• " Docstrings
• # Inline comments
• No documentation needed

[codecov]

Codecov Report

❌ Patch coverage is 79.25170% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.18%. Comparing base (91177eb) to head (34807b8).

Files with missing lines	Patch %	Lines
app/core/mypayment/endpoints_mypayment.py	61.97%	27 Missing ⚠️
app/core/mypayment/utils_mypayment.py	58.06%	26 Missing ⚠️
app/core/mypayment/cruds_mypayment.py	78.26%	5 Missing ⚠️
app/core/mypayment/exceptions_mypayment.py	72.72%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
- Coverage   84.43%   84.18%   -0.26%     
==========================================
  Files         206      205       -1     
  Lines       14918    15070     +152     
==========================================
+ Hits        12596    12686      +90     
- Misses       2322     2384      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Marc-Andrieu]

Somewhat hard to read, the distinction transfer vs. transaction needs to be very clear in mind given the two features you add in the same PR (I had to read some files again to be sure).
This is a very impressive PR!

[Marc-Andrieu]

It's not immediately obvious that these two schemas share a common structure with JWT stuff (key, iat), an amount, some unique ID and a related store.
I think it would be beneficial to factorize the common ground, something similar to this in my November PoC: https://github.com/aeecleclair/Hyperion/pull/896/changes#diff-2efdf688dfe95763d26d2cf79f3fc8678ea0c1a12dad36e55b0d51c71174b964

[Marc-Andrieu]

Supersedes #896