Add bump-dist CI workflow to replace a-frobot AWS instance#5813
Open
vincentfretin wants to merge 1 commit intoaframevr:masterfrom
Open
Add bump-dist CI workflow to replace a-frobot AWS instance#5813vincentfretin wants to merge 1 commit intoaframevr:masterfrom
vincentfretin wants to merge 1 commit intoaframevr:masterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the automated
dist/build process from the a-frobot AWS instance to a GitHub Actions workflow (.github/workflows/bump-dist.yml).Previously, an AWS instance running a-frobot would listen for pushes to master, rebuild the dist files, and commit them back. This PR replaces that with a native GitHub CI workflow.
What the workflow does
On every push to
masterthat touchessrc/,vendor/,package.json, orpackage-lock.json:npm ci(strict lockfile install, reproducible builds)npm run distto buildaframe-master.js,aframe-master.min.js, andaframe-master.module.min.jswith source mapsdist/README.mdto point to the new commit hashThe commit messages and format are identical to what a-frobot produced.
Changes compared to the a-frobot setup
package-lock.jsonchanges now trigger a rebuild - dependency updates that could affect the build output are no longer missed.npm ciinstead ofnpm install- ensures reproducible builds from the lockfile rather than potentially resolving new versions.github.actorisgithub-actions[bot], so the bot's own dist commits don't re-trigger a build.Configuration required (for repo owner)
Actions workflow permissions: Go to Settings > Actions > General > Workflow permissions and select "Read and write permissions". The workflow needs
contents: writeto push commits back to master.Branch protection rules (if any): If master has branch protection enabled, the default
GITHUB_TOKENcannot bypass it. You would need to:aframevr/aframewith Contents: Read and write permissionBUMP_DIST_PAT)token: ${{ secrets.BUMP_DIST_PAT }}Note: the existing
DEPLOY_PATsecret is scoped toaframevr/aframevr.github.iofor triggering site deploys, so it cannot be reused here.Retire a-frobot: Once the workflow is verified working, disable the a-frobot webhook/AWS instance for the dist bump task.