fix: avoid numpy truth-value ambiguity in keyword/structured search#56
Open
msaidbilgehan wants to merge 1 commit intoaiming-lab:mainfrom
Open
fix: avoid numpy truth-value ambiguity in keyword/structured search#56msaidbilgehan wants to merge 1 commit intoaiming-lab:mainfrom
msaidbilgehan wants to merge 1 commit intoaiming-lab:mainfrom
Conversation
…eads LanceDB returns `keywords`, `persons`, and `entities` columns as numpy arrays when read via `table.to_pandas()`. The existing `row["col"] or []` pattern triggers `ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()` because Python evaluates `bool(array)` for the `or` short-circuit. Replace the three occurrences in `keyword_search` and `structured_search` with the `is not None` idiom already used elsewhere in the file when building `MemoryEntry` objects, so behavior is consistent and safe for numpy-backed rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keyword search error: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()surfaced in server logs during hybrid or structured search.row["keywords"] or [](same pattern forpersons,entities) evaluatesbool(numpy_array), since LanceDB'sto_pandas()returns list columns as numpy arrays.is not Noneidiom already used when constructingMemoryEntryobjects in the same file.Test plan
memory_addsingle insert — no log errormemory_add_batchbulk insert — no log errormemory_query(exerciseskeyword_searchover 50+ rows) — no log errortruth value/ambiguousindocker logs